GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — [3.13] gh-117174: Adapt `test_multiple_statements_fail_early` to new REPL behavior (follow-up gh-131065) (GH-131836) by miss-islington · Pull Request #131841 · python/cpython Conversation
Contributor
Adapt test to new REPL behavior (follow-up gh-117174) Co-authored-by: Bartosz Sławecki [email protected]
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…EPL behavior (follow-up pythongh-131065) (pythonGH-131836) Adapt test to new REPL behavior (follow-up pythongh-117174) (cherry picked from commit a6cf827) Co-authored-by: Bartosz Sławecki <[email protected]>
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Oh, I see. gh-129488 added two new tests to the main branch:
They started failing upon changes related to gh-117174, which is why Pablo created gh-131065, which was merged 3 weeks ago. gh-129488 has been backported to 3.13 in gh-130513 very recently, readding these to the 3.13 branch:
Because the backport readded the latter test regardless of gh-131065, the buildbot reported failures for it. The reason this still fails is because I assumed that gh-130513 had been merged long ago, so I thought that gh-131065 wouldn't have to be manually applied to 3.13. So instead, I fixed the first test, which had never been an issue, but the actual fix (gh-131065) was never applied to 3.13, because gh-130513 hadn't been merged back then. The simplest way to get out of this situation is to cherry-pick gh-131065 to this PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@Yhg1s I don't have permissions to write to backport branches. Could you please cherry-pick/reapply gh-131065 in this PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Ah, and the most important part: conclusions. Before merging an old PR, it's good to re-run CI on it after refreshing it. Will remember to do that with my PRs 🫡 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-131850 is the backport of the other fix. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@bswck Thanks for sorting out the test failures :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.