GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-117174: Adapt `test_multiple_statements_fail_early` to new REPL behavior (follow-up gh-131065) (GH-131836) by miss-islington · Pull Request #131841 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 28, 2025

Copy link
Copy Markdown
Contributor

Adapt test to new REPL behavior (follow-up gh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@johnslavik @miss-islington
pythongh-117174: Adapt test_multiple_statements_fail_early to new R…
7378c3d
…EPL behavior (follow-up pythongh-131065) (pythonGH-131836)

Adapt test to new REPL behavior (follow-up pythongh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <[email protected]>
@bedevere-app bedevere-app Bot added the skip news label Mar 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2025
gh-117174: Adapt test_multiple_statements_fail_early to new REPL behavior (follow-up gh-131065) #131836
Merged
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2025
linecache.cache sometimes has an entry for <string> under Python 3.13.0a5 #117174
Closed
@Yhg1s
Yhg1s enabled auto-merge (squash) March 28, 2025 14:10
@Yhg1s

Yhg1s commented Mar 28, 2025

Copy link
Copy Markdown
Member

@bswck unfortunately it doesn't look like the fix in GH-131836 was enough to fix the failures in 3.13.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

Looking at it

Yhg1s reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The error isn't relevant to this fix, but to the fix in gh-131065, which was not backported.
It must have been overlooked that the test does exist in 3.13. Backporting gh-131065 should solve this problem.

Hm, no, I got lost.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Oh, I see.

gh-129488 added two new tests to the main branch:

  • (3.14) Lib.test.test_pyrepl.test_interact.TestSimpleInteract.test_multiple_statements_fail_early
  • (3.14) Lib.test.test_repl.TestAsyncioREPL.test_multiple_statements_fail_early

They started failing upon changes related to gh-117174, which is why Pablo created gh-131065, which was merged 3 weeks ago.

gh-129488 has been backported to 3.13 in gh-130513 very recently, readding these to the 3.13 branch:

  • (3.13) Lib.test.test_pyrepl.test_interact.TestSimpleInteract.test_multiple_statements_fail_early
  • (3.13) Lib.test.test_repl.TestAsyncioREPL.test_multiple_statements_fail_early

Because the backport readded the latter test regardless of gh-131065, the buildbot reported failures for it.

The reason this still fails is because I assumed that gh-130513 had been merged long ago, so I thought that gh-131065 wouldn't have to be manually applied to 3.13. So instead, I fixed the first test, which had never been an issue, but the actual fix (gh-131065) was never applied to 3.13, because gh-130513 hadn't been merged back then.

The simplest way to get out of this situation is to cherry-pick gh-131065 to this PR.
It's not bad that gh-131836 was merged to main (just unnecessary?), but we also need to reapply gh-131065 here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@Yhg1s I don't have permissions to write to backport branches. Could you please cherry-pick/reapply gh-131065 in this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@johnslavik

johnslavik commented Mar 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Ah, and the most important part: conclusions. Before merging an old PR, it's good to re-run CI on it after refreshing it. Will remember to do that with my PRs 🫡

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Yhg1s

Yhg1s commented Mar 28, 2025

Copy link
Copy Markdown
Member

GH-131850 is the backport of the other fix.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Yhg1s
Merge branch '3.13' into backport-a6cf827-3.13
859f1be
@Yhg1s
Yhg1s disabled auto-merge March 28, 2025 16:24
@Yhg1s
Yhg1s enabled auto-merge (squash) March 28, 2025 16:25
@Yhg1s
Yhg1s merged commit 3e45b1f into python:3.13 Mar 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 28, 2025
@Yhg1s

Yhg1s commented Mar 28, 2025

Copy link
Copy Markdown
Member

@bswck Thanks for sorting out the test failures :)

johnslavik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington deleted the backport-a6cf827-3.13 branch January 2, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @Yhg1s @johnslavik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.