GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-128231: Use `runcode()` return value for failing early (GH-129488) by miss-islington · Pull Request #130513 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 7ed3dc6)

Co-authored-by: Bartosz Sławecki [email protected]

  • Issue: In the new REPL, multiline input execution should fail fast #128231

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@johnslavik @miss-islington
pythongh-128231: Use runcode() return value for failing early (pyth…
2a59b10 
…onGH-129488)

(cherry picked from commit 7ed3dc6)

Co-authored-by: Bartosz Sławecki <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners February 24, 2025 14:50
@bedevere-app bedevere-app Bot added the topic-repl Related to the interactive shell label Feb 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 24, 2025
gh-128231: Use runcode() return value for failing early #129488
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Feb 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 24, 2025
In the new REPL, multiline input execution should fail fast #128231
Closed
@kumaraditya303 kumaraditya303 assigned encukou Feb 27, 2025
@kumaraditya303
kumaraditya303 removed their request for review March 25, 2025 09:08
@hugovk
hugovk merged commit 8f6a9aa into python:3.13 Mar 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 28, 2025
@hugovk

hugovk commented Mar 28, 2025

Copy link
Copy Markdown
Member

This 3.13 backport is failing GHA and buildbots, it must have gotten out of sync between last CI run and merge.

  • https://github.com/python/cpython/actions/runs/14127683394/job/39580397911
  • gh-128231: Use runcode() return value for failing early #129488 (comment)

Let's revert this 3.13 backport to get the CI back to green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

My intuition is that it can be simply worked-around by not printing a literal value, but e.g. 'after' + 'wards'. I suspect the input got into output, and that causes the failure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 28, 2025
@hugovk
Revert "[3.13] pythongh-128231: Use runcode() return value for fail…
f32bd0a 
…ing early (pythonGH-129488) (python#130513)"

This reverts commit 8f6a9aa.
@hugovk hugovk mentioned this pull request Mar 28, 2025
[3.13] Revert "gh-128231: Use runcode() return value for failing early (GH-129488) (#130513)" #131834
Closed
@hugovk

hugovk commented Mar 28, 2025

Copy link
Copy Markdown
Member

In the meantime, I've made PR #131834 to revert.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

GH-131834 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

Fixing in the original branch (#129488).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

I guess I'll need to open another PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 28, 2025
gh-117174: Adapt test_multiple_statements_fail_early now that we have always source #131065
Merged
[3.13] gh-117174: Adapt test_multiple_statements_fail_early to new REPL behavior (follow-up gh-131065) (GH-131836) #131841
Merged
@miss-islington
miss-islington deleted the backport-7ed3dc6-3.13 branch January 2, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @hugovk @johnslavik @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.