GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117174: Adapt test_multiple_statements_fail_early now that we have always source by pablogsal · Pull Request #131065 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Mar 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: linecache.cache sometimes has an entry for <string> under Python 3.13.0a5 #117174

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-117174: Adapt test_multiple_statements_fail_early now that w…
d3b8b4e 
…e have always source
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Mar 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2025
linecache.cache sometimes has an entry for <string> under Python 3.13.0a5 #117174
Closed
@pablogsal pablogsal mentioned this pull request Mar 10, 2025
gh-130804: Fix support of typing unicode chars in pyrepl #130805
Merged
@pablogsal pablogsal self-assigned this Mar 10, 2025
@pablogsal pablogsal added needs backport to 3.13 only security fixes skip news labels Mar 10, 2025
@pablogsal
pablogsal enabled auto-merge (squash) March 10, 2025 22:52
@pablogsal
pablogsal merged commit 4192ce1 into python:main Mar 10, 2025
@pablogsal
pablogsal deleted the 117174-2 branch March 10, 2025 23:10
@miss-islington-app

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 10, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4192ce17ba643e5b0bc9d2182a429002e4cc9dfe 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Mar 10, 2025

Copy link
Copy Markdown
Member Author

Thios doesn't need to be backported to 3.13 because the test doesn't exist there
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou removed the needs backport to 3.13 only security fixes label Mar 11, 2025
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

Related to #130513 (the cause of failures).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik

johnslavik commented Mar 28, 2025

Copy link
Copy Markdown
Member

@hugovk if we fix the failure as in this PR, the buildbot should pass.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@johnslavik johnslavik mentioned this pull request Mar 28, 2025
gh-117174: Adapt test_multiple_statements_fail_early to new REPL behavior (follow-up gh-131065) #131836
Merged
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@johnslavik
gh-117174: Adapt test_multiple_statements_fail_early to new REPL be…
a6cf827 
…havior (follow-up gh-131065) (#131836)

Adapt test to new REPL behavior (follow-up gh-117174)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
@johnslavik @miss-islington
pythongh-117174: Adapt test_multiple_statements_fail_early to new R…
7378c3d 
…EPL behavior (follow-up pythongh-131065) (pythonGH-131836)

Adapt test to new REPL behavior (follow-up pythongh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <[email protected]>
@johnslavik johnslavik mentioned this pull request Mar 28, 2025
[3.13] gh-117174: Adapt test_multiple_statements_fail_early to new REPL behavior (follow-up gh-131065) (GH-131836) #131841
Merged
@Yhg1s Yhg1s added the needs backport to 3.13 only security fixes label Mar 28, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2025
@pablogsal @miss-islington
pythongh-117174: Adapt test_multiple_statements_fail_early now that w…
2d86629 
…e have always source (pythonGH-131065)

(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 28, 2025

Copy link
Copy Markdown

GH-131850 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 28, 2025
@Yhg1s

Yhg1s commented Mar 28, 2025

Copy link
Copy Markdown
Member

(Test now does exist in 3.13 so the fix needs backporting.)
johnslavik reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @pablogsal
[3.13] gh-117174: Adapt test_multiple_statements_fail_early now that …
e460602 
…we have always source (GH-131065) (#131850)

gh-117174: Adapt test_multiple_statements_fail_early now that we have always source (GH-131065)
(cherry picked from commit 4192ce1)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Yhg1s pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @johnslavik
[3.13] gh-117174: Adapt test_multiple_statements_fail_early to new …
3e45b1f 
…REPL behavior (follow-up gh-131065) (GH-131836) (#131841)

gh-117174: Adapt `test_multiple_statements_fail_early` to new REPL behavior (follow-up gh-131065) (GH-131836)

Adapt test to new REPL behavior (follow-up gh-117174)
(cherry picked from commit a6cf827)

Co-authored-by: Bartosz Sławecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @johnslavik @Yhg1s @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.