GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130662: accept leading zeros in precision/width for Decimal's formatting by skirpichev · Pull Request #132549 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Apr 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: format(Fraction(1, 3), '.016f') raises ValueError #130662

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev
pythongh-130662: accept leading zeros in precision/width for Decimal'…
75fde5d 
…s formatting
@bedevere-app bedevere-app Bot added the awaiting review label Apr 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 15, 2025
format(Fraction(1, 3), '.016f') raises ValueError #130662
Closed
@skirpichev skirpichev added the skip news label Apr 15, 2025
@vstinner

This comment was marked as resolved.

Sign in to view
vstinner
vstinner approved these changes Apr 15, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 15, 2025
@skirpichev skirpichev added the 3.14 bugs and security fixes label Apr 28, 2025
@skirpichev skirpichev added needs backport to 3.14 bugs and security fixes and removed 3.14 bugs and security fixes labels May 8, 2025
@skirpichev
skirpichev requested review from picnixz and serhiy-storchaka June 2, 2025 06:29
picnixz

This comment was marked as resolved.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 2 commits June 2, 2025 14:32
@skirpichev
Merge branch 'master' into fix-fmt-decimal/130662
d0cef91
@skirpichev
address review: add news
251ce80
@skirpichev
skirpichev requested a review from picnixz June 2, 2025 11:38
picnixz
picnixz approved these changes Jun 2, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-06-02-14-36-28.gh-issue-130662.Gpr2GB.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev @picnixz
Update Misc/NEWS.d/next/Library/2025-06-02-14-36-28.gh-issue-130662.G…
eb4d8b4 
…pr2GB.rst

Co-authored-by: Bénédikt Tran <[email protected]>
@vstinner vstinner removed the needs backport to 3.14 bugs and security fixes label Jun 2, 2025
@vstinner
vstinner merged commit 9c72658 into python:main Jun 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 2, 2025
@picnixz picnixz removed the skip news label Jun 2, 2025
@vstinner

vstinner commented Jun 2, 2025

Copy link
Copy Markdown
Member

Merged, thank you.

I don't think that this change should be backported to stable branches.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
skirpichev deleted the fix-fmt-decimal/130662 branch June 2, 2025 13:57
@skirpichev skirpichev mentioned this pull request Jul 7, 2025
Add underscore as a decimal separator for string formatting #87790
Closed
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@skirpichev @picnixz @miss-islington
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
19a5631 
…s formatting (pythonGH-132549)

(cherry picked from commit 9c72658)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136362 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
@miss-islington @skirpichev @picnixz
[3.14] gh-130662: Accept leading zeros in precision/width for Decimal…
f87578f 
…'s formatting (GH-132549) (#136362)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev @picnixz @Pranjal095
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
cd79e61 
…s formatting (python#132549)

Co-authored-by: Bénédikt Tran <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@skirpichev @picnixz @taegyunkim
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
f3edd38 
…s formatting (python#132549)

Co-authored-by: Bénédikt Tran <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@skirpichev @picnixz @Agent-Hellboy
pythongh-130662: Accept leading zeros in precision/width for Decimal'…
333591c 
…s formatting (python#132549)

Co-authored-by: Bénédikt Tran <[email protected]>
@rffontenelle rffontenelle mentioned this pull request Oct 26, 2026
gh-130662: Remove unnecessary plus sign from news entry #160723
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@picnixz picnixz picnixz approved these changes
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@skirpichev @vstinner @picnixz @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.