GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130662: Remove unnecessary plus sign from news entry by rffontenelle · Pull Request #160723 · python/cpython

Conversation

@rffontenelle

@rffontenelle rffontenelle commented Oct 26, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove leading plus sign added in #132549 from NEWS entry.

Ultimately, the leading plus sign may cause Sphinx warning if a translator doesn't write +:class:`~decimal.Decimal` like the original like:

build/NEWS:8698: WARNING: inconsistent cross-references in translated message. original: ['`~decimal.Decimal`'], translated: [':class:`~decimal.Decimal`'] [i18n.inconsistent_references]

See Brazilian Portuguese translation for instance. Notice how the original message (msgid) has a plus sign write before the class role and the translation message (msgstr) doesn't, which caused the above warning:

#: ../NEWS:8672
msgid ":gh:`130662`: +Accept leading zeros in precision and width fields for +:"class:`~decimal.Decimal` formatting, for example ``format(Decimal(1.25), '.016f')``."
msgstr ":gh:`130662`: Aceita zeros à esquerda em campos de precisão e largura para formatação :class:`~decimal.Decimal`, por exemplo ``format(Decimal(1.25), '.016f')``."

The Sphinx warning was spotted in https://translations.python.org/build-details.html, browsing the pt-br count.

  • Issue: format(Fraction(1, 3), '.016f') raises ValueError #130662

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rffontenelle
Remove unecessary plus sign from news entry
b894ae4
@bedevere-app bedevere-app Bot added the awaiting review label Oct 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 26, 2026
format(Fraction(1, 3), '.016f') raises ValueError #130662
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Oct 26, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Oct 26, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 26, 2026
@rffontenelle rffontenelle changed the title gh-130662: Remove unecessary plus sign from news entry gh-130662: Remove unnecessary plus sign from news entry Oct 26, 2026
m-aciek
m-aciek approved these changes Oct 26, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 26, 2026
@StanFromIreland StanFromIreland added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 26, 2026
StanFromIreland
StanFromIreland approved these changes Oct 26, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 26, 2026
@StanFromIreland
StanFromIreland merged commit 3acc941 into python:main Oct 26, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 26, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

Thanks @rffontenelle for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 26, 2026
@StanFromIreland

StanFromIreland commented Oct 26, 2026

Copy link
Copy Markdown
Member

Merged, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

Sorry, @rffontenelle and @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 3acc941f2b7288b212a4163ab21aa79faff9cd13 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned StanFromIreland Oct 26, 2026
@bedevere-app

bedevere-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

GH-160729 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 26, 2026
@rffontenelle
rffontenelle deleted the patch-5 branch October 26, 2026 17:50
@bedevere-app

bedevere-app Bot commented Oct 26, 2026

Copy link
Copy Markdown

GH-160730 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 26, 2026
@StanFromIreland

StanFromIreland commented Oct 26, 2026

Copy link
Copy Markdown
Member

Merged, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rffontenelle

rffontenelle commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland This is an entry for 3.15 alpha NEWS, so I assume it doesn't apply to 3.14 (sorry for not mentioning it before).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Oct 26, 2026

Copy link
Copy Markdown
Member

It was backported to 3.14, so it does. I made a backport in #160730.
rffontenelle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland pushed a commit that referenced this pull request Oct 26, 2026
@miss-islington @rffontenelle
[3.15] gh-130662: Remove unnecessary plus sign from a news entry (GH-…
1a31558 
…160723) (#160729)

(cherry picked from commit 3acc941)

Co-authored-by: Rafael Fontenelle <[email protected]>
StanFromIreland added a commit that referenced this pull request Oct 26, 2026
@StanFromIreland
[3.14] gh-130662: Remove unnecessary plus sign from a news entry (#16…
6f41d73 
…0723) (#160730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-aciek m-aciek m-aciek approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@StanFromIreland StanFromIreland

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rffontenelle @StanFromIreland @m-aciek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.