GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-63882: Break down `and` tests in `test_minidom` by StanFromIreland · Pull Request #133026 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Apr 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

First part, up to 750 lines. Continues my previous work.

Did these by hand, they should be all right now ;-)

request: @picnixz @hugovk

  • Issue: test_minidom has many empty tests #63882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
commit
3ce0b35
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 26, 2025
test_minidom has many empty tests #63882
Closed
@picnixz picnixz changed the title gh-63882: Use self.assert* in test_minidom gh-63882: Break down and tests in test_minidom Apr 26, 2025
@hugovk hugovk added the skip news label May 5, 2025
hugovk
hugovk approved these changes May 5, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 5, 2025
@hugovk hugovk added the needs backport to 3.13 only security fixes label May 5, 2025
@hugovk
hugovk enabled auto-merge (squash) May 5, 2025 15:54
@hugovk
hugovk merged commit e294e16 into python:main May 5, 2025
@miss-islington-app

miss-islington-app Bot commented May 5, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 5, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2025
@StanFromIreland @miss-islington
pythongh-63882: Break down and tests in test_minidom (pythonGH-13…
906a6d6 
…3026)

(cherry picked from commit e294e16)

Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app

bedevere-app Bot commented May 5, 2025

Copy link
Copy Markdown

GH-133451 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 5, 2025
@StanFromIreland
StanFromIreland deleted the minidom-750-up branch May 5, 2025 16:08
hugovk pushed a commit that referenced this pull request May 5, 2025
@miss-islington @StanFromIreland
[3.13] gh-63882: Break down and tests in test_minidom (GH-133026) (…
d84a762 
…#133451)

Co-authored-by: Stan Ulbrych <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@StanFromIreland @Pranjal095
pythongh-63882: Break down and tests in test_minidom (python#133026)
7677686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@StanFromIreland @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.