GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-91048: Minor fixes for ``_remotedebugging`` & rename to ``_remote_debugging`` by AA-Turner · Pull Request #133398 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @pablogsal, a few minor things I spotted after the rename in #133284.

Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and _remote_debugging would better match the C files.

A

  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 2 commits May 4, 2025 20:42
@AA-Turner
Minor fixes after renaming to _remotedebugging
794075f
@AA-Turner
Sorting
90b4d18
@AA-Turner AA-Turner added the skip news label May 4, 2025
@AA-Turner
AA-Turner requested review from a team, corona10 and erlend-aasland as code owners May 4, 2025 19:49
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Async Call-Stack Reconstruction #91048
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2025
pablogsal
pablogsal approved these changes May 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 4, 2025
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Thanks a lot for the fix @AA-Turner!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and _remote_debugging would better match the C files.

Yep, if you want, go ahead and make the changes
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner commented May 4, 2025
View reviewed changes
Comment thread configure.ac Outdated
PY_STDLIB_MOD([readline],
[], [test "$with_readline" != "no"],
[$READLINE_CFLAGS], [$READLINE_LIBS])
PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes])

@AA-Turner AA-Turner May 4, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal should we keep this "$TEST_MODULES" = yes condition? It's inherited from before the rename, but I don't know what conditions you want the module to be enabled under.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal May 4, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, that was from before when this was a test module. Let's remove it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner May 4, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've pushed a fix for this & also the rename to _remote_debugging. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Rename to _remote_debugging
2e6b80e
@AA-Turner
AA-Turner requested review from 1st1, asvetlov, kumaraditya303 and willingc as code owners May 4, 2025 20:06
@AA-Turner
AA-Turner removed request for a team, 1st1, asvetlov, corona10, erlend-aasland, kumaraditya303 and willingc May 4, 2025 20:06
@AA-Turner AA-Turner changed the title GH-91048: Minor fixes after renaming to _remotedebugging GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging May 4, 2025
@AA-Turner AA-Turner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
@bedevere-bot

bedevere-bot commented May 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AA-Turner for commit 2e6b80e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133398%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2025
AA-Turner added 2 commits May 4, 2025 21:29
@AA-Turner
Merge branch 'main' into remote-debug-misc
67f415f 
# Conflicts:
#	PCbuild/pcbuild.sln
@AA-Turner
make regen-stdlib-module-names
163b8e4
@pablogsal

pablogsal commented May 4, 2025

Copy link
Copy Markdown
Member

Hummmm, seems that this collided with the other PR, could you rebase? I can land it afterwards.

If you don't have time I can rebase myself if you prefer :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Merge branch 'main' into remote-debug-misc
d53db6b 
# Conflicts:
#	Lib/test/test_external_inspection.py
@AA-Turner

AA-Turner commented May 4, 2025

Copy link
Copy Markdown
Member Author

Thanks! resolved conflicts

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 3f80165 into python:main May 5, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 5, 2025
@pablogsal

pablogsal commented May 5, 2025

Copy link
Copy Markdown
Member

Thanks again 🖤
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the remote-debug-misc branch May 5, 2025 00:34
@zanieb zanieb mentioned this pull request May 17, 2025
Update to 3.14.0b1 astral-sh/python-build-standalone#610
Merged
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request Jun 4, 2025
@zanieb @Wingysam @geofft
Update to 3.14.0b1 (#610)
d2030cb 
- python/cpython#133027
- python/cpython#133366
- python/cpython#133284
- python/cpython#133398
- python/cpython#131298
- python/cpython#132438
- python/cpython#133012

---------

Co-authored-by: Wingy <[email protected]>
Co-authored-by: Geoffrey Thomas <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@AA-Turner @Pranjal095
pythonGH-91048: Minor fixes for _remotedebugging & rename to ``_r…
e2c898b 
…emote_debugging`` (python#133398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.