GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131298: update Modules/Setup after HACL static linking changes by asottile · Pull Request #133012 · python/cpython

Conversation

@asottile

@asottile asottile commented Apr 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

looks like this was missed in #132438

this fixes the deadsnakes nightly builds

  • Issue: Undefined references to HACL symbols when statically linking Python 3.12 #131298

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@asottile
update Modules/Setup after HACL static linking changes
cca76e6 
looks like this was missed in python#132438
@asottile
asottile requested a review from erlend-aasland as a code owner April 26, 2025 15:14
@bedevere-app bedevere-app Bot added the awaiting review label Apr 26, 2025
@asottile asottile mentioned this pull request Apr 26, 2025
gh-131298: eliminate HACL* static libraries for cryptographic modules #132438
Merged
@picnixz picnixz changed the title update Modules/Setup after HACL static linking changes gh-131298: update Modules/Setup after HACL static linking changes Apr 26, 2025
@picnixz picnixz added the skip news label Apr 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 26, 2025
Undefined references to HACL symbols when statically linking Python 3.12 #131298
Closed
@picnixz

picnixz commented Apr 26, 2025

Copy link
Copy Markdown
Member

Oh thanks, I forgot!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 26, 2025
@bedevere-bot

bedevere-bot commented Apr 26, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit cca76e6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133012%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 26, 2025
@picnixz
picnixz merged commit bd2e5f0 into python:main Apr 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 26, 2025
@picnixz

picnixz commented Apr 26, 2025

Copy link
Copy Markdown
Member

Thanks for the fix!
asottile reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asottile
asottile deleted the patch-4 branch April 26, 2025 16:56
@picnixz picnixz mentioned this pull request Apr 27, 2025
gh-133042: disable HACL* HMAC on Emscripten #133064
Merged
@zanieb zanieb mentioned this pull request May 18, 2025
Update to 3.14.0b1 astral-sh/python-build-standalone#610
Merged
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request Jun 4, 2025
@zanieb @Wingysam @geofft
Update to 3.14.0b1 (#610)
d2030cb 
- python/cpython#133027
- python/cpython#133366
- python/cpython#133284
- python/cpython#133398
- python/cpython#131298
- python/cpython#132438
- python/cpython#133012

---------

Co-authored-by: Wingy <[email protected]>
Co-authored-by: Geoffrey Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@asottile @picnixz @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.