GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-132983: Convert zstd ``__new__`` methods to Argument Clinic (GH-133860) by miss-islington · Pull Request #133915 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit d29ddbd)

Co-authored-by: Adam Turner [email protected]

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner @miss-islington
pythongh-132983: Convert zstd __new__ methods to Argument Clinic (p…
8f70e8d 
…ythonGH-133860)

(cherry picked from commit d29ddbd)

Co-authored-by: Adam Turner <[email protected]>
This was referenced May 12, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
gh-132983: Convert zstd __new__ methods to Argument Clinic #133860
Merged
@bedevere-app bedevere-app Bot added skip news awaiting review labels May 12, 2025
@AA-Turner
AA-Turner enabled auto-merge (squash) May 12, 2025 08:53
AA-Turner
AA-Turner approved these changes May 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 12, 2025
@AA-Turner
ABI
79c7443
@AA-Turner
AA-Turner requested a review from encukou as a code owner May 12, 2025 09:13
@AA-Turner
AA-Turner disabled auto-merge May 12, 2025 09:13
@AA-Turner

AA-Turner commented May 12, 2025

Copy link
Copy Markdown
Member

cc @hugovk as RM for ABI check (failing run) -- we removed dict_content from global strings, so _PyRuntimeState has changed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner requested a review from hugovk May 12, 2025 09:18
@encukou

encukou commented May 13, 2025

Copy link
Copy Markdown
Member

The commit for main seems to have caused reference leaks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented May 13, 2025

Copy link
Copy Markdown
Member

See #133962 for a fix-up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes May 19, 2025
View reviewed changes
@AA-Turner
AA-Turner merged commit 4effd06 into python:3.14 May 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2025
@miss-islington
miss-islington deleted the backport-d29ddbd-3.14 branch January 2, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@encukou encukou Awaiting requested review from encukou encukou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @AA-Turner @encukou @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.