GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ by encukou · Pull Request #133962 · python/cpython

Conversation

@encukou

@encukou encukou commented May 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This will call tp_dealloc and clear all members.

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Call Py_XDECREF rather than PyObject_GC_Del in failed __new__
abbdc96 
This will call tp_dealloc and clear all members.
@bedevere-app bedevere-app Bot mentioned this pull request May 13, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@bedevere-app bedevere-app Bot added the awaiting core review label May 13, 2025
@encukou
encukou requested a review from AA-Turner May 13, 2025 06:50
@encukou encukou added the skip news label May 13, 2025
This was referenced May 13, 2025
[3.14] gh-132983: Convert zstd __new__ methods to Argument Clinic (GH-133860) #133915
Merged
gh-132983: Convert zstd __new__ methods to Argument Clinic #133860
Merged
serhiy-storchaka
serhiy-storchaka reviewed May 13, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also https://github.com/python/cpython/pull/133924/files#r2084922874

There may be other similar errors in these files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

encukou commented May 13, 2025

Copy link
Copy Markdown
Member Author

I'll merge to fix the tier-1 buildbot; further fix-ups welcome.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit e575190 into python:main May 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 13, 2025
serhiy-storchaka
serhiy-storchaka approved these changes May 13, 2025
View reviewed changes
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 13, 2025
@miss-islington-app

miss-islington-app Bot commented May 13, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented May 13, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e575190abbd9409adad3e7fd95424f827236bed9 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou May 13, 2025
@AA-Turner

AA-Turner commented May 13, 2025

Copy link
Copy Markdown
Member

Thanks for the fix & merge @encukou -- backport will fail as the original commit isn't yet backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels May 20, 2025
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@encukou @miss-islington
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
8216650 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
(cherry picked from commit e575190)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134305 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
AA-Turner pushed a commit that referenced this pull request May 20, 2025
@miss-islington @encukou
[3.14] gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in fail…
07a2033 
…ed __new__ (GH-133962) (#134305)

gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ (GH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
(cherry picked from commit e575190)

Co-authored-by: Petr Viktorin <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
bcce301 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-132983: Call Py_XDECREF rather than PyObject_GC_Del in faile…
c184336 
…d __new__ (pythonGH-133962)

Call Py_XDECREF rather than PyObject_GC_Del in failed __new__

This will call tp_dealloc and clear all members.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @AA-Turner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.