GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Convert zstd __new__ methods to Argument Clinic by AA-Turner · Pull Request #133860 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented May 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • merge the tp_init functions into tp_new and convert the latter to AC. This also means we can remove the initialised member from the object structs.
  • Change the signature of ZstdDict to make the content positional-only and is_raw kw-only.
  • Use Zstandard where appropriate to refer to the compression algorithm, instead of the reference implementation.

A

cc @Rogdham

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 6 commits May 11, 2025 03:07
@AA-Turner
Convert zstd __new__ methods to Argument Clinic
2273bce
@AA-Turner
Merge _zstd_ZstdDict___init__ into _zstd_ZstdDict_new
2ac1885
@AA-Turner
Merge _zstd_ZstdDecompressor___init__ into _zstd_ZstdDecompressor_new
0ca7db8
@AA-Turner
Merge _zstd_ZstdCompressor___init__ into _zstd_ZstdCompressor_new
98ee61a
@AA-Turner
post-merge tweaks
15fc9ce
@AA-Turner
Consistently use Zstandard vs zstd
4cc2d4e
@AA-Turner
AA-Turner requested a review from emmatyping May 11, 2025 02:42
@AA-Turner AA-Turner added skip news needs backport to 3.14 bugs and security fixes labels May 11, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label May 11, 2025
@AA-Turner AA-Turner changed the title gh-133856: Convert zstd __new__ methods to Argument Clinic gh-132983: Convert zstd __new__ methods to Argument Clinic May 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 11, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
AA-Turner added 2 commits May 11, 2025 11:25
@AA-Turner
regen-all
e8aac00
@AA-Turner
remove now-unneeded <stdbool.h> include directives
fe03b15
emmatyping
emmatyping reviewed May 12, 2025
View reviewed changes
Comment thread Modules/_zstd/zstddict.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
emmatyping
emmatyping reviewed May 12, 2025
View reviewed changes
Comment thread Modules/_zstd/zstddict.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
emmatyping
emmatyping approved these changes May 12, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions but otherwise looks great!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
tweak comments
bb6c416
@AA-Turner
AA-Turner enabled auto-merge (squash) May 12, 2025 08:24
@AA-Turner
AA-Turner merged commit d29ddbd into python:main May 12, 2025
@miss-islington-app

miss-islington-app Bot commented May 12, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label May 12, 2025
@AA-Turner
AA-Turner deleted the zstd-ac-new branch May 12, 2025 08:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2025
@AA-Turner @miss-islington
pythongh-132983: Convert zstd __new__ methods to Argument Clinic (p…
8f70e8d 
…ythonGH-133860)

(cherry picked from commit d29ddbd)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented May 12, 2025

Copy link
Copy Markdown

GH-133915 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 12, 2025
@encukou encukou mentioned this pull request May 13, 2025
[3.14] gh-132983: Convert zstd __new__ methods to Argument Clinic (GH-133860) #133915
Merged
@encukou

encukou commented May 13, 2025

Copy link
Copy Markdown
Member

Since this was merged, buildbots started showing reference leaks, e.g. here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented May 13, 2025

Copy link
Copy Markdown
Member

See #133962 for a fix-up.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added a commit that referenced this pull request May 20, 2025
@miss-islington @AA-Turner
[3.14] gh-132983: Convert zstd __new__ methods to Argument Clinic (…
4effd06 
…GH-133860) (#133915)

Co-authored-by: Adam Turner <[email protected]>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@AA-Turner @Pranjal095
pythongh-132983: Convert zstd __new__ methods to Argument Clinic (p…
6fee7c7 
…ython#133860)
@corneliusroemer corneliusroemer mentioned this pull request Jul 22, 2025
Typo "algorthm" in 7 zstd module prologue comment files #136975
Closed
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@AA-Turner @taegyunkim
pythongh-132983: Convert zstd __new__ methods to Argument Clinic (p…
832e602 
…ython#133860)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @encukou @emmatyping
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.