GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: defer removal of bundled libmpdec to 3.16 by skirpichev · Pull Request #133997 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented May 14, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unvendor libmpdec sources #115119

📚 Documentation preview 📚: https://cpython-previews--133997.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@skirpichev
pythongh-115119: defer removal of bundled libmpdec to 3.16
3d1a11d
@skirpichev
skirpichev requested a review from AA-Turner May 14, 2025 11:00
@skirpichev skirpichev added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 14, 2025
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label May 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 14, 2025
Unvendor libmpdec sources #115119
Closed
15 tasks done
@bedevere-app bedevere-app Bot added skip news awaiting review labels May 14, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs May 14, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 14, 2025
@skirpichev
+1
5aeaa36
StanFromIreland
StanFromIreland reviewed May 14, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
skirpichev requested a review from hugovk May 15, 2025 06:47
skirpichev added 2 commits May 15, 2025 13:04
@skirpichev
Merge branch 'master' into defer-libmpdec-removal/115119
baf8767
@skirpichev
+ update configuire.ac
0110402
@skirpichev
skirpichev requested review from corona10 and erlend-aasland as code owners May 15, 2025 10:04
@skirpichev

skirpichev commented May 15, 2025

Copy link
Copy Markdown
Member Author

Oops, this seems to be not just a docs patch. I hope this still ok for backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev mentioned this pull request May 16, 2025
gh-115119: removed implicit fallback to the bundled libmpdec #134078
Merged
@skirpichev
skirpichev requested review from picnixz and vstinner May 30, 2025 05:41
picnixz
picnixz reviewed Jun 2, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say but I'm neutral on delaying the removal.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk removed their request for review June 2, 2025 11:06
@vstinner

vstinner commented Jun 2, 2025

Copy link
Copy Markdown
Member

defer removal of bundled libmpdec to 3.16

What is the rationale for defering the removal?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

What is the rationale for defering the removal?

You can see the issue thread.

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now #134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Jun 2, 2025

Copy link
Copy Markdown
Member

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy

I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jun 3, 2025

Copy link
Copy Markdown
Member Author

FYI, I restored removal PR: #133964. I think libmpdec can be installed from PPA for PHP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added 2 commits June 3, 2025 09:03
@skirpichev
Merge branch 'master' into defer-libmpdec-removal/115119
1653751
@skirpichev
rename libmpdecimal -> libmpdec
8f7a642 
see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
@skirpichev
skirpichev requested a review from StanFromIreland June 3, 2025 06:24
@hugovk

hugovk commented Jun 10, 2025

Copy link
Copy Markdown
Member

An RM decision isn't needed for normal feature changes in main aka 3.15. (And if it's deferred to 3.16, it's even less of this RM's decision :)

https://devguide.python.org/developer-workflow/development-cycle/#in-development-main-branch
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

Deferring a breaking change is always a good thing :-)

Maybe.

An RM decision isn't needed for normal feature changes in main aka 3.15.

This affects 3.14 as well, as we change announced plans.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jul 1, 2025

Copy link
Copy Markdown
Member

Since #134078 was just merged in Python 3.15, I think that it would be safe to postpone the removal to Python 3.16. Have one release with #134078 to see how it goes.

@skirpichev: There are now merge conflicts, can you try to address them?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichev

skirpichev commented Jul 1, 2025

Copy link
Copy Markdown
Member Author

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual). It's expected to be merged first, not after #134078.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
Merge branch 'master' into defer-libmpdec-removal/115119
0891537
@skirpichev skirpichev added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichev
skirpichev requested a review from vstinner July 1, 2025 16:42
@vstinner vstinner removed needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 2, 2025
@vstinner
vstinner merged commit b19c9da into python:main Jul 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 2, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 2, 2025
@vstinner

vstinner commented Jul 2, 2025

Copy link
Copy Markdown
Member

Merged.

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual).

Do you mean that it doesn't make sense to backport this change, or that it should be backported manually?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev
skirpichev deleted the defer-libmpdec-removal/115119 branch July 2, 2025 09:32
@skirpichev

skirpichev commented Jul 2, 2025

Copy link
Copy Markdown
Member Author

Do you mean that it doesn't make sense to backport this change

No, it does!

that it should be backported manually?

Yes. I'll do this.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.14] pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
ac33099 
…thonGH-133997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 2, 2025

Copy link
Copy Markdown

GH-136199 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.13] pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
79caac3 
…thonGH-133997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 2, 2025

Copy link
Copy Markdown

GH-136201 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.14] gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
23a990d 
… (#136199)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)
vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.13] gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
1e6db47 
… (#136201)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <[email protected]>
@vstinner

vstinner commented Jul 2, 2025

Copy link
Copy Markdown
Member

I merged the 3.13 and 3.14 backports, thanks.
skirpichev reacted with thumbs up emoji erlend-aasland reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@skirpichev @AndPuQing
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
d9021b2 
…3997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@skirpichev @Pranjal095
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
22b9910 
…3997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@skirpichev @picnixz
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
98d96e0 
…3997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@skirpichev @taegyunkim
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
a6f3560 
…3997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@skirpichev @Agent-Hellboy
pythongh-115119: Defer removal of bundled libmpdec to 3.16 (python#13…
175adab 
…3997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@picnixz picnixz Awaiting requested review from picnixz
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@skirpichev @vstinner @AA-Turner @hugovk @picnixz @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.