GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134036: Improve error messages for invalid `raise` statements by sobolevn · Pull Request #134077 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented May 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Снимок экрана 2025-05-16 в 09 07 44

Better error message wordings are welcome!

  • Issue: Improve raise from ValueError() error message #134036

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-134036: Improve error messages for invalid raise statements
d8c385a
@sobolevn
sobolevn requested review from lysnikolaou and pablogsal as code owners May 16, 2025 06:09
@bedevere-app bedevere-app Bot mentioned this pull request May 16, 2025
Improve raise from ValueError() error message #134036
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 16, 2025
lysnikolaou
lysnikolaou approved these changes Jun 5, 2025
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's simple enough that shouldn't create any problems and it is a clear improvement.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 5, 2025
pablogsal
pablogsal approved these changes Jun 6, 2025
View reviewed changes
@pablogsal

pablogsal commented Jun 6, 2025

Copy link
Copy Markdown
Member

Great improvement! ❤️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 0d9ccc8 into python:main Jun 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 6, 2025
@Wulian233

Wulian233 commented Jun 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@pablogsal @sobolevn this commit causes all the latest PR test checks to fail, such as #135002 #131796 and #135198 .

It's all because of the

1 test failed:
test_syntax
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Jun 6, 2025

Copy link
Copy Markdown
Member

I think this passed pre-merge CI but failed post-merge because rebasing it is what broke it... We can roll this back or it can be fixed-forward. If this can't be fixed quickly it should be rolled back. (/cc @hugovk.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2025
gh-133390: Support SQL keyword completion for sqlite3 CLI #133393
Merged
@vstinner

vstinner commented Jun 6, 2025

Copy link
Copy Markdown
Member

I wrote #135204 to update test_syntax, the fix is trivial (update error messages).
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz mentioned this pull request Jun 14, 2025
Invalid error messages after GH-134077 #135422
Closed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-134036: Improve error messages for invalid raise statements (
9aa467f 
python#134077)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn @taegyunkim
pythongh-134036: Improve error messages for invalid raise statements (
c98fc9c 
python#134077)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sobolevn @Agent-Hellboy
pythongh-134036: Improve error messages for invalid raise statements (
58453c1 
python#134077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou lysnikolaou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @pablogsal @Wulian233 @Yhg1s @vstinner @lysnikolaou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.