GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135001: Explicitly specify the encoding parameter value of `calendar.HTMLCalendar` as 'utf-8' by Wulian233 · Pull Request #135002 · python/cpython

Conversation

@Wulian233

@Wulian233 Wulian233 commented Jun 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8'  #135001

📚 Documentation preview 📚: https://cpython-previews--135002.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Wulian233
Change the default *encoding* of calendar.HTMLCalendar to UTF-8
68bd800
@bedevere-app bedevere-app Bot added the awaiting review label Jun 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 1, 2025
Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' #135001
Closed
@Wulian233 Wulian233 changed the title gh-135001: Change the default parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 Jun 1, 2025
picnixz
picnixz reviewed Jun 1, 2025
View reviewed changes
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz marked this pull request as draft June 1, 2025 12:07
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 1, 2025
@picnixz

picnixz commented Jun 1, 2025

Copy link
Copy Markdown
Member

Making it a draft as it's a WIP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
Wulian233 marked this pull request as ready for review June 1, 2025 13:00
@bedevere-app bedevere-app Bot added the awaiting review label Jun 1, 2025
@Wulian233
Wulian233 requested a review from picnixz June 1, 2025 13:39
picnixz
picnixz previously requested changes Jun 2, 2025
View reviewed changes
Comment thread Lib/test/test_calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jun 2, 2025
@bedevere-app

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233

Wulian233 commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

The new commit resolves the above review and requires you to confirm that it is resolved. Thanks!

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Jun 2, 2025
@bedevere-app

bedevere-app Bot commented Jun 2, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from picnixz June 2, 2025 08:38
picnixz
picnixz reviewed Jun 2, 2025
View reviewed changes
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/calendar.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2025-06-01-19-45-55.gh-issue-135001.KsBXSl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz dismissed their stale review June 2, 2025 08:43

.

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting change review labels Jun 2, 2025
vstinner
vstinner reviewed Jun 5, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner reviewed Jun 5, 2025
View reviewed changes
Comment thread Lib/test/test_calendar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
Wulian233 force-pushed the calendar branch from d37c9cc to 68bd800 Compare June 6, 2025 01:12
@Wulian233
fix
a232d70
@Wulian233 Wulian233 changed the title gh-135001: Change the default encoding parameter value of calendar.HTMLCalendar to utf-8 gh-135001: Explicitly specify the encoding parameter value of calendar.HTMLCalendar as 'utf-8' Jun 6, 2025
@Wulian233
fix
a0465f3
@Wulian233
lint
f5da0b9
@Wulian233

Wulian233 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

sys.getdefaultencoding() always returns "utf-8", so this PR doesn't change the default encoding. If you want, you can replace sys.getdefaultencoding() with "utf-8". But I don't think that it should be documented.

I just using git reset was not the right thing to do, and I apologize for that. I honestly didn’t consider this at the time

I’ve added a news entry, do you think that’s necessary?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
Merge branch 'main' into calendar
dd69284
@Wulian233 Wulian233 mentioned this pull request Jun 6, 2025
gh-134036: Improve error messages for invalid raise statements #134077
Merged
@vstinner

vstinner commented Jun 6, 2025

Copy link
Copy Markdown
Member

I’ve added a news entry, do you think that’s necessary?

I don't think that it's necessary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
Delete Misc/NEWS.d/next/Library/2025-06-06-09-20-46.gh-issue-135001.z…
bf55ca4 
…otIVz.rst
vstinner
vstinner approved these changes Jun 9, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 9, 2025
@vstinner
Merge branch 'main' into calendar
5618fa0
@vstinner

vstinner commented Jun 9, 2025

Copy link
Copy Markdown
Member

test_syntax was failing on the CI. I updated the branch to try to repair the CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Jun 9, 2025
@vstinner
vstinner merged commit f90483e into python:main Jun 9, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 9, 2025
@vstinner

vstinner commented Jun 9, 2025

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Wulian233
Wulian233 deleted the calendar branch June 9, 2025 13:51
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Wulian233 @lkollar
pythongh-135001: Explicitly specify the encoding parameter value of `…
1b2c7a3 
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Wulian233 @Pranjal095
pythongh-135001: Explicitly specify the encoding parameter value of `…
40e6367 
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Wulian233 @taegyunkim
pythongh-135001: Explicitly specify the encoding parameter value of `…
246473b 
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Wulian233 @Agent-Hellboy
pythongh-135001: Explicitly specify the encoding parameter value of `…
f5f6eef 
…calendar.HTMLCalendar` as 'utf-8' (python#135002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Wulian233 @picnixz @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.