GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx by corona10 · Pull Request #134238 · python/cpython

Conversation

@corona10

@corona10 corona10 commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Data race on block->next in mi_block_set_nextx #129748

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
Data race on block->next in mi_block_set_nextx #129748
Closed
@corona10
corona10 requested a review from colesbury May 19, 2025 15:02
@corona10 corona10 added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 19, 2025
@corona10
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
ae8cfb6 
…_nextx
@corona10
corona10 force-pushed the gh-129748 branch from bc94b14 to ae8cfb6 Compare May 19, 2025 18:32
@corona10
corona10 marked this pull request as ready for review May 19, 2025 19:24
@bedevere-app bedevere-app Bot added the awaiting core review label May 19, 2025
@corona10
corona10 requested a review from Yhg1s May 19, 2025 19:25
@corona10

corona10 commented May 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Following code is now fully okay with this PR.

https://gist.github.com/duaneg/59ec54d52e19a7ad52d8c4d82ef8e9fb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added the topic-free-threading label May 19, 2025
colesbury
colesbury approved these changes May 20, 2025
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 20, 2025
@corona10
corona10 merged commit 317c496 into python:main May 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2025
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@corona10 @miss-islington
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
e624962 
…_nextx (pythonGH-134238)

(cherry picked from commit 317c496)

Co-authored-by: Donghee Na <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@corona10 @miss-islington
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
931bec7 
…_nextx (pythonGH-134238)

(cherry picked from commit 317c496)

Co-authored-by: Donghee Na <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134352 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134353 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2025
corona10 added a commit that referenced this pull request May 20, 2025
@miss-islington @corona10
[3.14] gh-129748: Update mimalloc to use atomic store for mi_block_se…
dc5866a 
…t_nextx (GH-134238) (gh-134352)

gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx (GH-134238)
(cherry picked from commit 317c496)

Co-authored-by: Donghee Na <[email protected]>
corona10 added a commit that referenced this pull request May 20, 2025
@miss-islington @corona10
[3.13] gh-129748: Update mimalloc to use atomic store for mi_block_se…
bad9f63 
…t_nextx (GH-134238) (gh-134353)

gh-129748: Update mimalloc to use atomic store for mi_block_set_nextx (GH-134238)
(cherry picked from commit 317c496)

Co-authored-by: Donghee Na <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@corona10 @lkollar
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
718505c 
…_nextx (python#134238)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@corona10 @Pranjal095
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
14fce87 
…_nextx (python#134238)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@corona10 @taegyunkim
pythongh-129748: Update mimalloc to use atomic store for mi_block_set…
bf49758 
…_nextx (python#134238)
colesbury added a commit that referenced this pull request Dec 17, 2025
@colesbury
gh-129748: Remove TSan suppression for mi_block_set_nextx (gh-142887)
6e625f8 
The function was already changed to use a relaxed atomic store in gh-134238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.