GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase by AlexKautz · Pull Request #134372 · python/cpython

Conversation

@AlexKautz

@AlexKautz AlexKautz commented May 20, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Added a clarification that the underlying binary buffer of a TextIOBase
can be a BufferedIOBase OR a RawIOBase.

RawIOBase was previously not specified because it is a edge case (was recently added along with non-buffered mode).

  • Issue: io.TextIOBase.buffer is not necessarily a buffer #85045

📚 Documentation preview 📚: https://cpython-previews--134372.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@python-cla-bot

python-cla-bot Bot commented May 20, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request May 20, 2025
io.TextIOBase.buffer is not necessarily a buffer #85045
Closed
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 20, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs May 20, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs May 20, 2025
@gpshead gpshead self-assigned this May 20, 2025
AlexKautz added 2 commits May 20, 2025 14:10
@AlexKautz Alex Kautz
Added a clarification
58ac46f 
that the underlying binary buffer of a TextIOBase
can be a BufferedIOBase OR a RawIOBase
@AlexKautz Alex Kautz
Fixed whitespace
169c954
@AlexKautz
AlexKautz force-pushed the 85045-io.TextIOBase.buffer-is-not-necessarily-a-buffer branch from 678ebbb to 169c954 Compare May 20, 2025 18:11
Alex Kautz
Merge branch 'main' into 85045-io.TextIOBase.buffer-is-not-necessaril…
e634bda 
…y-a-buffer
gpshead
gpshead approved these changes May 20, 2025
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 20, 2025
@gpshead
gpshead enabled auto-merge (squash) May 20, 2025 18:14
@gpshead gpshead added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels May 20, 2025
@gpshead gpshead moved this from Todo to In Progress in Docs PRs May 20, 2025
@gpshead
gpshead merged commit 36eb711 into python:main May 20, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Docs PRs May 20, 2025
@miss-islington-app

miss-islington-app Bot commented May 20, 2025

Copy link
Copy Markdown

Thanks @AlexKautz for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label May 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
Alex Kautz @miss-islington
pythongh-85045: clarified that the underlying buffer of a TextIOBase …
d495021 
…can be a RawIOBase (pythonGH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
(cherry picked from commit 36eb711)

Co-authored-by: Alex Kautz <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
Alex Kautz @miss-islington
pythongh-85045: clarified that the underlying buffer of a TextIOBase …
5a6c3dc 
…can be a RawIOBase (pythonGH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
(cherry picked from commit 36eb711)

Co-authored-by: Alex Kautz <[email protected]>
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134374 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
@bedevere-app

bedevere-app Bot commented May 20, 2025

Copy link
Copy Markdown

GH-134375 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label May 20, 2025
gpshead pushed a commit that referenced this pull request May 20, 2025
@miss-islington Alex Kautz
[3.14] gh-85045: clarified that the underlying buffer of a TextIOBase…
899ce7d 
… can be a RawIOBase (GH-134372) (#134374)

gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
(cherry picked from commit 36eb711)

Co-authored-by: Alex Kautz <[email protected]>
gpshead pushed a commit that referenced this pull request May 20, 2025
@miss-islington Alex Kautz
[3.13] gh-85045: clarified that the underlying buffer of a TextIOBase…
7df6749 
… can be a RawIOBase (GH-134372) (#134375)

gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
(cherry picked from commit 36eb711)

Co-authored-by: Alex Kautz <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
Alex Kautz @lkollar
pythongh-85045: clarified that the underlying buffer of a TextIOBase …
2170fab 
…can be a RawIOBase (pythonGH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
Alex Kautz @Pranjal095
pythongh-85045: clarified that the underlying buffer of a TextIOBase …
85c2bd6 
…can be a RawIOBase (pythonGH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Alex Kautz @taegyunkim
pythongh-85045: clarified that the underlying buffer of a TextIOBase …
02cc7bc 
…can be a RawIOBase (pythonGH-134372)

Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexKautz @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.