GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: JIT: Optimize `_CALL_TYPE_1` when the result is known by tomasr8 · Pull Request #135194 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jun 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Followup to #134369 (comment)

This completely removes _CALL_TYPE_1 when the abstract interpreter is able to deduce the result (by knowing the type of the argument).

For example, for something like type(42), we currently do

_LOAD_CONST_INLINE_BORROW (callable: type)
_PUSH_NULL
_LOAD_CONST_INLINE_BORROW (arg: 42)
_CALL_TYPE_1

Note that we still do the call even when we know the result.

In this PR, when the result is known, _CALL_TYPE_1 is replaced with _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW:

_LOAD_CONST_INLINE_BORROW (callable: type)
_PUSH_NULL
_LOAD_CONST_INLINE_BORROW (arg: 42)
- _CALL_TYPE_1
+ _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW (arg: int)

Thanks to some previous work on optimizing remove_unneeded_uops this becomes just:

_LOAD_CONST_INLINE_BORROW (arg: int)

that is, the entire call is replaced with a load.

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
tomasr8 added 2 commits June 5, 2025 21:56
@tomasr8
Optimize _CALL_TYPE_1
e8ae8f5
@tomasr8
Add news entry
8110987
@tomasr8
tomasr8 requested a review from Fidget-Spinner as a code owner June 5, 2025 20:16
@bedevere-app bedevere-app Bot added the awaiting review label Jun 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 5, 2025
Better uop coverage in the JIT optimizer #131798
Open
@tomasr8
Merge branch 'main' into optimize-call-type-1
705fbc8
Fidget-Spinner
Fidget-Spinner approved these changes Jun 6, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 6, 2025
@tomasr8

tomasr8 commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

The test failures should be fixed by #135204, let me update main to make sure CI is all green :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tomasr8
Merge branch 'main' into optimize-call-type-1
46b97b4
brandtbucher
brandtbucher approved these changes Jun 6, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even more JIT magic, I love it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tomasr8 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
Comment thread Lib/test/test_capi/test_opt.py
self.assertEqual(res, TIER2_THRESHOLD)
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_CALL_TYPE_1", uops)

@brandtbucher brandtbucher Jun 6, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool when older tests like this "break" with a new optimization. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@brandtbucher
brandtbucher merged commit 4615164 into python:main Jun 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 6, 2025
@tomasr8
tomasr8 deleted the optimize-call-type-1 branch June 7, 2025 06:03
@tomasr8 tomasr8 mentioned this pull request Jun 8, 2025
gh-131798: JIT: Optimize _CALL_LEN when the length is known #135260
Merged
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@tomasr8 @Pranjal095
pythonGH-131798: Optimize away type(x) in the JIT when the result is …
b155ac6
…known (pythonGH-135194)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@tomasr8 @taegyunkim
pythonGH-131798: Optimize away type(x) in the JIT when the result is …
84dae66
…known (pythonGH-135194)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@tomasr8 @Agent-Hellboy
pythonGH-131798: Optimize away type(x) in the JIT when the result is …
8b6870e
…known (pythonGH-135194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tomasr8 @Fidget-Spinner @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.