GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: JIT: Optimize _CALL_LEN when the length is known by tomasr8 · Pull Request #135260 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jun 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This uses the same principle as #135194 to completely remove _CALL_LEN when the length is known.

I don't know how common it is to actually know the length exactly so please let me know if this is not worth it, but given that _CALL_LEN is the most common builtin call, it felt worth to optimize this case.

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tomasr8 added 2 commits June 8, 2025 14:24
@tomasr8
Add news entry
2763b89
@tomasr8
Optimize _CALL_LEN
bcbf1ff
@tomasr8
tomasr8 requested a review from Fidget-Spinner as a code owner June 8, 2025 12:58
@bedevere-app bedevere-app Bot added the awaiting review label Jun 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 8, 2025
Better uop coverage in the JIT optimizer #131798
Open
tomasr8
tomasr8 commented Jun 8, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
Comment on lines +1195 to +1207
int tuple_length = sym_tuple_length(arg);
if (tuple_length >= 0) {
PyObject *temp = PyLong_FromLong(tuple_length);
if (temp == NULL) {
goto error;
}
if (_Py_IsImmortal(temp)) {
REPLACE_OP(this_instr, _POP_CALL_ONE_LOAD_CONST_INLINE_BORROW,
0, (uintptr_t)temp);
}
res = sym_new_const(ctx, temp);
Py_DECREF(temp);
}

@tomasr8 tomasr8 Jun 8, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically copied from the recent _GET_LEN optimization

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
tomasr8 requested a review from brandtbucher June 8, 2025 15:44
@tomasr8
Simplify tests
a411a58
brandtbucher
brandtbucher approved these changes Jun 9, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll leave this for you to merge yourself. ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 reacted with heart emoji tomasr8 reacted with eyes emoji
All reactions
  • ❤️ 1 reaction
  • 👀 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 9, 2025
@tomasr8
Merge remote-tracking branch 'upstream/main' into jit-call-len-known-…
b218fb5 
…length
@tomasr8

tomasr8 commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

I'm planning to merge this once the tests pass :)
Fidget-Spinner reacted with heart emoji brandtbucher reacted with rocket emoji
All reactions
  • ❤️ 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
tomasr8 merged commit 61532b4 into python:main Jun 20, 2025
@tomasr8
tomasr8 deleted the jit-call-len-known-length branch June 20, 2025 16:21
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 20, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@tomasr8 @Pranjal095
pythongh-131798: JIT: Optimize _CALL_LEN when the length is known (py…
5ebde87 
…thon#135260)

* Add news entry

* Optimize _CALL_LEN

* Simplify tests
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@tomasr8 @taegyunkim
pythongh-131798: JIT: Optimize _CALL_LEN when the length is known (py…
94e90a0 
…thon#135260)

* Add news entry

* Optimize _CALL_LEN

* Simplify tests
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@tomasr8 @Agent-Hellboy
pythongh-131798: JIT: Optimize _CALL_LEN when the length is known (py…
13e4aca 
…thon#135260)

* Add news entry

* Optimize _CALL_LEN

* Simplify tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tomasr8 @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.