GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92266: Replace tabs with four spaces in Python files by hugovk · Pull Request #135983 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jun 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

make patchcheck used to be part of the CI, and it also used to run Tools/patchcheck/reindent.py.

reindent.py includes a few lints:

  • strip trailing whitespace (now done by trailing-whitespace in CI via pre-commit)
  • replace tabs with spaces
  • reindent to multiples of four-space indents

This PR re-adds the second of these to the CI via pre-commit.

(The second and third of these can be done by Black and Ruff, but they also do all the other formatting changes which we've not agreed upon yet.)

  • Issue: make patchcheck: Allow Tabs in Some Cases #92266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Replace tabs with four spaces in Python files
335b7aa
@hugovk
hugovk requested a review from AlexWaygood as a code owner June 26, 2025 13:08
@hugovk hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jun 26, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 26, 2025
make patchcheck: Allow Tabs in Some Cases #92266
Closed
@hugovk hugovk added the skip news label Jun 26, 2025
AlexWaygood
AlexWaygood approved these changes Jun 26, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 26, 2025
@hugovk
hugovk merged commit de0d014 into python:main Jun 27, 2025
@hugovk
hugovk deleted the 3.15-pre-commit-remove-tabs branch June 27, 2025 13:23
@miss-islington-app

miss-islington-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 27, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@hugovk @miss-islington
pythongh-92266: Replace tabs with four spaces in Python files (python…
ba155d1 
…GH-135983)

(cherry picked from commit de0d014)

Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@hugovk @miss-islington
pythongh-92266: Replace tabs with four spaces in Python files (python…
1ef6e99 
…GH-135983)

(cherry picked from commit de0d014)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136035 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025
@bedevere-app

bedevere-app Bot commented Jun 27, 2025

Copy link
Copy Markdown

GH-136036 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jun 27, 2025
hugovk added a commit that referenced this pull request Jun 27, 2025
@miss-islington @hugovk
[3.14] gh-92266: Replace tabs with four spaces in Python files (GH-13…
7e4637e 
…5983) (#136035)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Jun 27, 2025
@miss-islington @hugovk
[3.13] gh-92266: Replace tabs with four spaces in Python files (GH-13…
1e972c7 
…5983) (#136036)

Co-authored-by: Hugo van Kemenade <[email protected]>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@hugovk @AndPuQing
pythongh-92266: Replace tabs with four spaces in Python files (python…
9f48f74 
…#135983)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hugovk @Pranjal095
pythongh-92266: Replace tabs with four spaces in Python files (python…
0659dcb 
…#135983)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hugovk @taegyunkim
pythongh-92266: Replace tabs with four spaces in Python files (python…
2d7d981 
…#135983)
@AA-Turner AA-Turner mentioned this pull request Aug 10, 2025
GH-92266: Remove embedded tabs from c-analyzer/cpython/_parser.py #137622
Merged
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hugovk @Agent-Hellboy
pythongh-92266: Replace tabs with four spaces in Python files (python…
4b616bb 
…#135983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.