GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-92266: Remove embedded tabs from ``c-analyzer/cpython/_parser.py`` by AA-Turner · Pull Request #137622 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an attempt to avoid some of the problems we've seen with embedded tabs by changing the global variables within c-analyzer/cpython/_parser.py to use more structured data.

The output is identical, save for INCL_DIRS, where the fourth line (* ./Include/internal/mimalloc) currently uses spaces instead of tabs, showing that the current format is quite hard to properly keep up to date. The errant line was added in #109914.

What do you think @ericsnowcurrently?

See also:

  • make patchcheck: Allow Tabs in Some Cases #92266
  • gh-92266: Replace tabs with four spaces in Python files #135983
  • gh-92266: reindent.py: Add allowlist for files with tabs #135984
  • Issue: make patchcheck: Allow Tabs in Some Cases #92266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Remove embedded tabs from c-analyzer/cpython/_parser.py
847bccc
@AA-Turner
AA-Turner requested a review from ericsnowcurrently as a code owner August 10, 2025 23:55
@AA-Turner AA-Turner added the skip news label Aug 10, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 10, 2025
make patchcheck: Allow Tabs in Some Cases #92266
Closed
AA-Turner
AA-Turner commented Aug 10, 2025
View reviewed changes
Comment thread Tools/c-analyzer/cpython/_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner commented Aug 10, 2025
View reviewed changes
Comment thread Tools/c-analyzer/cpython/_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently
ericsnowcurrently approved these changes Sep 17, 2025
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with your own suggested changes applied)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/c-analyzer/cpython/_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 17, 2025
AA-Turner added 2 commits September 17, 2025 15:57
@AA-Turner
Split format_table_lines() & apply suggestions
f1cfdd9
@AA-Turner
Merge branch 'main' into c-analyzer-embedded-tabs
af0394d 
# Conflicts:
#	Tools/c-analyzer/cpython/_parser.py
@AA-Turner
AA-Turner enabled auto-merge (squash) September 17, 2025 15:14
@AA-Turner
AA-Turner merged commit 2212ae5 into python:main Sep 17, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 17, 2025
@AA-Turner
AA-Turner deleted the c-analyzer-embedded-tabs branch September 17, 2025 15:25
@hugovk hugovk mentioned this pull request Oct 1, 2025
[3.14] gh-92266: Update pre-commit (GH-139411) #139466
Merged
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Oct 7, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 7, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2025
@AA-Turner @miss-islington
pythonGH-92266: Remove embedded tabs from ``c-analyzer/cpython/_parse…
df89f5f 
…r.py`` (pythonGH-137622)

(cherry picked from commit 2212ae5)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 7, 2025

Copy link
Copy Markdown

GH-139718 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 7, 2025
AA-Turner added a commit that referenced this pull request Oct 7, 2025
@miss-islington @AA-Turner
[3.14] GH-92266: Remove embedded tabs from ``c-analyzer/cpython/_pars…
db8b943 
…er.py`` (GH-137622) (#139718)

GH-92266: Remove embedded tabs from ``c-analyzer/cpython/_parser.py`` (GH-137622)
(cherry picked from commit 2212ae5)

Co-authored-by: Adam Turner <[email protected]>
@hugovk hugovk mentioned this pull request Oct 8, 2025
[3.13] gh-92266: Update pre-commit (GH-139411) #139760
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.