GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-67341: fix comment about windows link stat mapping by moreal · Pull Request #136049 · python/cpython Conversation
|
|
Hello, thanks for your interest in contributing! I see that your prior PR, #136027, was accepted, but please don't use that as a green light to make several PRs fixing comment typos. These generally fall under the umbrella of "cosmetic changes", which we try to avoid. That said, this PR is already here, so we might as well use it. Are there any other comment fixes you would like to make? Let's do it all in one change, rather than many tiny changes; it's easier for us to handle from a review stance. After this one, please try to avoid sole comment changes. Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hello, thank you for letting me know about that policy! I apologize for taking up the maintainers' attention. I was referencing the CPython source code while working on other tasks, and these were comment errors I discovered in that process, so there are no additional fixes to add. The reason it became 2 PRs is because I submitted them as I found them while reading through the source code. Next time, even if I discover such issues (cosmetic changes), I'll just understand and move on without submitting fixes. Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
b64d3ae to
131d398
Compare
131d398 to
691d76e
Compare
|
FYI, no need to force push. We squash at the end. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yeah I've accepted the other PR because it's annoying when a comment is wrong especially when it's about defining stuff. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
`IO_REPARSE_TAG_SYMLINK` is mapped to `S_IFLNK` in `fileutils.c`, not in `posixmodule.c`
`IO_REPARSE_TAG_SYMLINK` is mapped to `S_IFLNK` in `fileutils.c`, not in `posixmodule.c`
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
fstat64 required on Windows
There was an error while loading. Please reload this page.