GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Emscripten: Fix test_open_undecodable_uri by setting `-sTEXTDECODER=2` by hoodmane · Pull Request #136624 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jul 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Fix test_open_undecodable_uri by setting `-sTEXTDECO…
358e0a3 
…DER=2`

This removes the JS text decoder fallback and gets rid of the bugs
due to the differences in behavior on invalid utf8 strings.
See emscripten-core/emscripten#24690.
@hoodmane
hoodmane requested a review from freakboy3742 July 13, 2025 12:22
@hoodmane
hoodmane requested review from corona10 and erlend-aasland as code owners July 13, 2025 12:22
@bedevere-app bedevere-app Bot added the awaiting review label Jul 13, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 13, 2025
Emscripten: Get test suite passing #127146
Closed
@hoodmane hoodmane changed the title gh-127146: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 Jul 13, 2025
@hoodmane hoodmane added OS-emscripten skip news labels Jul 13, 2025
@hoodmane

hoodmane commented Jul 13, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 13, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 358e0a3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136624%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jul 13, 2025
freakboy3742
freakboy3742 approved these changes Jul 13, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it resolves the test failures in CI, so I'll call that a win

(EDIT: There are still other failures, but this patch results in less failures, and specifically no failure with the sqlite3 tests.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 13, 2025
@freakboy3742
freakboy3742 merged commit 283b050 into python:main Jul 13, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 13, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 13, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Fix test_open_undecodable_uri by setting…
e660f71 
… `-sTEXTDECODER=2` (pythonGH-136624)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 13, 2025

Copy link
Copy Markdown

GH-136631 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 13, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 14, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Fix test_open_undecodable_uri by settin…
2618180 
…g `-sTEXTDECODER=2` (GH-136624) (#136631)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham <[email protected]>
hoodmane added a commit to hoodmane/cpython that referenced this pull request Jul 16, 2025
@hoodmane
pythongh-127146: Emscripten: Don't need to avoid unpaired surrogate a…
41f0124 
…nymore

This might have been fixed by pythongh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
@hoodmane hoodmane mentioned this pull request Jul 16, 2025
gh-127146: Emscripten: Don't need to avoid unpaired surrogate anymore #136707
Merged
hoodmane added a commit to hoodmane/pyodide that referenced this pull request Jul 16, 2025
@hoodmane
Link with -sTEXTDECODER=2
a4ca905 
This makes the code smaller and gets rid of a buggy code path. We
switched to this upstream to fix a test: see python/cpython#136624.
@hoodmane hoodmane mentioned this pull request Jul 16, 2025
Link with -sTEXTDECODER=2 pyodide/pyodide#5776
Draft
freakboy3742 pushed a commit that referenced this pull request Jul 16, 2025
@hoodmane
gh-127146: Emscripten: Don't need to avoid unpaired surrogate anymore (…
dcd27aa 
…#136707)

This might have been fixed by gh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Don't need to avoid unpaired surrogate a…
ae27905 
…nymore (pythonGH-136707)

This might have been fixed by pythongh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
(cherry picked from commit dcd27aa)

Co-authored-by: Hood Chatham <[email protected]>
@miss-islington miss-islington mentioned this pull request Jul 16, 2025
[3.14] gh-127146: Emscripten: Don't need to avoid unpaired surrogate anymore (GH-136707) #136717
Merged
freakboy3742 pushed a commit that referenced this pull request Jul 16, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Don't need to avoid unpaired surrogate …
9b7c418 
…anymore (GH-136707) (#136717)

This might have been fixed by gh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
(cherry picked from commit dcd27aa)

Co-authored-by: Hood Chatham <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Emscripten: Fix test_open_undecodable_uri by setting…
69aaa91 
… `-sTEXTDECODER=2` (python#136624)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences 
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Emscripten: Don't need to avoid unpaired surrogate a…
83abe8c 
…nymore (python#136707)

This might have been fixed by pythongh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Emscripten: Fix test_open_undecodable_uri by setting…
77e5568 
… `-sTEXTDECODER=2` (python#136624)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences 
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Emscripten: Don't need to avoid unpaired surrogate a…
d5e24ba 
…nymore (python#136707)

This might have been fixed by pythongh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: Fix test_open_undecodable_uri by …
cbf6ad2 
…setting `-sTEXTDECODER=2` (pythonGH-136624) (python#136631)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: Don't need to avoid unpaired surr…
f6e104e 
…ogate anymore (pythonGH-136707) (python#136717)

This might have been fixed by pythongh-136624, or by some Emscripten change.
In any case, it no longer seems to be needed.
(cherry picked from commit dcd27aa)

Co-authored-by: Hood Chatham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.