GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-127146: Emscripten: Fix test_open_undecodable_uri by setting `-sTEXTDECODER=2` (GH-136624) by miss-islington · Pull Request #136631 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham [email protected]

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane @miss-islington
pythongh-127146: Emscripten: Fix test_open_undecodable_uri by setting…
e660f71 
… `-sTEXTDECODER=2` (pythonGH-136624)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham <[email protected]>
@miss-islington
miss-islington requested review from corona10 and erlend-aasland as code owners July 13, 2025 18:30
@bedevere-app bedevere-app Bot added awaiting review skip news labels Jul 13, 2025
This was referenced Jul 13, 2025
gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 #136624
Merged
Emscripten: Get test suite passing #127146
Closed
@freakboy3742

freakboy3742 commented Jul 13, 2025

Copy link
Copy Markdown
Contributor

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 13, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit e660f71 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136631%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 approved these changes Jul 14, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 14, 2025
@freakboy3742
freakboy3742 merged commit 2618180 into python:3.14 Jul 14, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 14, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: Fix test_open_undecodable_uri by …
cbf6ad2 
…setting `-sTEXTDECODER=2` (pythonGH-136624) (python#136631)

Removes the JS text decoder fallback and gets rid of the bugs due to the differences
in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
(cherry picked from commit 283b050)

Co-authored-by: Hood Chatham <[email protected]>
@miss-islington
miss-islington deleted the backport-283b050-3.14 branch January 2, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @freakboy3742 @bedevere-bot @hoodmane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.