GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111968: remove redundant fetching of interpreter state in dict implementation by kumaraditya303 · Pull Request #136673 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This removes the redundant fetching of interpreter state where it is not needed now. This is leftover from #114323 when freelist was per-interpreter rather than per-thread in free-threading.

  • Issue: Use per-thread freelists in --disable-gil builds #111968

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
remove redundant calls to fetch interpreter state in dict
79e6db3
@kumaraditya303
kumaraditya303 requested review from markshannon and methane as code owners July 15, 2025 10:15
@kumaraditya303 kumaraditya303 added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 15, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 15, 2025
Use per-thread freelists in --disable-gil builds #111968
Closed
@kumaraditya303 kumaraditya303 changed the title gh-111968: remove redundant calls to fetch interpreter state in dict gh-111968: remove redundant fetching of interpreter state in dict implementation Jul 15, 2025
@kumaraditya303
kumaraditya303 merged commit a8f42e6 into python:main Jul 15, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 15, 2025
@kumaraditya303
kumaraditya303 deleted the dict2 branch July 15, 2025 13:45
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-111968: remove redundant fetching of interpreter state in `d…
0dcd696 
…ict` implementation (python#136673)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-111968: remove redundant fetching of interpreter state in `d…
8b027dc 
…ict` implementation (python#136673)
@kumaraditya303 kumaraditya303 mentioned this pull request Dec 17, 2025
Many functions in dictobject.c take a PyInterpreterState *interp parameter, but none of them use it. #142890
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.