GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Many functions in dictobject.c take a `PyInterpreterState *interp` parameter, but none of them use it. · Issue #142890 · python/cpython

Many functions in dictobject.c take a PyInterpreterState *interp parameter, but none of them use it. #142890

New issue
Copy link
New issue
Copy link
Closed
Closed
Many functions in dictobject.c take a PyInterpreterState *interp parameter, but none of them use it.#142890
Copy link
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

Description

@markshannon
markshannon
opened on Dec 17, 2025
Issue body actions

The parameter was introduced when the global dictionary version number was moved to the interpreter state.
#102338

We no longer have a global dictionary version number so this parameter can be removed.
https://peps.python.org/pep-0699/

Linked PRs

  • gh-142890: remove unnecessary interp parameter from dict functions and _PyDict_NotifyEvent #142923
Reacted by Raymond Hettinger

Activity

  1. kumaraditya303 commented on Dec 17, 2025

    @kumaraditya303
    kumaraditya303
    on Dec 17, 2025
    Contributor
    More actions

    I had removed the redundant ones in #136673, the rest of functions need to it to call _PyDict_NotifyEvent. In which functions is it unused?

  2. aisk
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)
    type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)
    on Dec 17, 2025

  3. colesbury commented on Dec 17, 2025

    @colesbury
    colesbury
    on Dec 17, 2025
    Contributor
    More actions

    It looks like _PyDict_NotifyEvent doesn't use the interp argument, so we can probably remove it there too.

  4. kumaraditya303 commented on Dec 18, 2025

    @kumaraditya303
    kumaraditya303
    on Dec 18, 2025
    Contributor
    More actions

    #142923 removes it from rest of dict functions and _PyDict_NotifyEvent.

  5. kumaraditya303
    added a commit that references this issue on Dec 18, 2025

    gh-142890: remove unnecessary interp parameter from dict functions an…

    e22c495
  6. kumaraditya303
    closed this as completedon Dec 18, 2025
  7. cocolato
    added a commit that references this issue on Dec 18, 2025

    pythongh-142890: remove unnecessary interp parameter from dict functi…

    3c0a6c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)Code refactoring (with no changes in behavior)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.