GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||
GeezerVison is showing github.com — GH-130645: Default to color help in argparse by pablogsal · Pull Request #136809 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit 0abf68e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136809%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Man, this looks so good! Thanks for making the PR. Just one small comment re. docs!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
We've gotten a lot of approvals on this PR 😃 and I intend to merge it imminently. @hugovk We're good to get this into 3.14, yeah? If so, I'll add the backport to 3.14 label before merge. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, good to backport to 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @pablogsal for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit acbe896) Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
GH-136886 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
) GH-130645: Default to color help in argparse (GH-136809) (cherry picked from commit acbe896) Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> Co-authored-by: Adam Turner <[email protected]>
|
It seemed like the previous discussion at #130645 had the consensus of having this opt-in. I'm surprised to see this made opt-out now. For example, @savannahostrowski previously stated "I'm +1 on this, if it's opt-in" but appears to approve of this change. Other commenters from the previous thread that were also in support of making it opt-in include @rhettinger and @sobolevn but haven't commented on this issue. Concerns mentioned included start-up time and breaking of tests. No one in the previous issue made an argument for doing opt-out. It seems to me that making it opt-out is perhaps premature. Was this discussed somewhere else that I've missed? Thanks. Apologies if this isn't the right place to raise this, I'm not a contributor, I just saw the 3.14rc1 release and noticed this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@tgbrooks Yeah, I thought about this more, and I think the risk here is very low. @hugovk did a lot of due diligence around testing performance impact, making it respect |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> Co-authored-by: Adam Turner <[email protected]>
…" (#19721) Reverts #19021 After the PR was merged, `color` was changed to `true` for Python 3.14. Setting it manually is no longer necessary. python/cpython#136809 https://docs.python.org/3.14/library/argparse.html#color
…36809) (python#136886) pythonGH-130645: Default to color help in argparse (pythonGH-136809) (cherry picked from commit acbe896) Co-authored-by: Pablo Galindo Salgado <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> Co-authored-by: Adam Turner <[email protected]>
python/cpython#136809 made `color` default to True in ArgumentParser.
python/cpython#136809 made `color` default to True in ArgumentParser.
….14+. python/cpython#136809 made `color` default to True in ArgumentParser. Backport of d0d85cd from main.
….14+. python/cpython#136809 made `color` default to True in ArgumentParser. Backport of d0d85cd from main.
….14+. python/cpython#136809 made `color` default to True in ArgumentParser. Backport of d0d85cd from main.
python/cpython#136809 made `color` default to True in ArgumentParser.
python/cpython#136809 made `color` default to True in ArgumentParser.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.