GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions by savannahostrowski · Pull Request #139980 · python/cpython

Conversation

@savannahostrowski

@savannahostrowski savannahostrowski commented Oct 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The TestOptionalsHelpVersionActions test class is missing the @force_not_colorized_test_class decorator, causing test failures when running in terminals with TERM set and stdout as a TTY, as the tests expect plain text output.

I think this was missed in #136809

  • Issue: Add missing @force_not_colorized_test_class decorator to TestOptionalHelpVersionActions #139979

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
Add decorator to prevent color
96e647c
@savannahostrowski savannahostrowski added skip issue needs backport to 3.14 bugs and security fixes labels Oct 12, 2025
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Oct 12, 2025
@savannahostrowski savannahostrowski added skip news and removed skip issue labels Oct 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2025
Add missing @force_not_colorized_test_class decorator to TestOptionalHelpVersionActions #139979
Closed
@savannahostrowski savannahostrowski changed the title GH-139979: Add decorator to prevent color GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions Oct 12, 2025
hugovk
hugovk approved these changes Oct 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 12, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Oct 12, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@savannahostrowski
savannahostrowski merged commit 0fc5c56 into python:main Oct 12, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@savannahostrowski @miss-islington
pythonGH-139979: Add @force_not_colorized_test_class to TestOptionalH…
b9723d0 
…elpVersionActions (pythonGH-139980)

(cherry picked from commit 0fc5c56)

Co-authored-by: Savannah Ostrowski <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

GH-140005 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
savannahostrowski added a commit that referenced this pull request Oct 12, 2025
@miss-islington @savannahostrowski
[3.14] GH-139979: Add @force_not_colorized_test_class to TestOptional…
11ac373 
…HelpVersionActions (GH-139980) (#140005)

GH-139979: Add @force_not_colorized_test_class to TestOptionalHelpVersionActions (GH-139980)
(cherry picked from commit 0fc5c56)

Co-authored-by: Savannah Ostrowski <[email protected]>
@savannahostrowski
savannahostrowski deleted the add-color-decorator branch December 4, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@savannahostrowski @hugovk @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.