GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-111758: Merge TSan and UBSan reusable GHA workflows by webknjaz · Pull Request #136820 · python/cpython

Conversation

@webknjaz

@webknjaz webknjaz commented Jul 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This patch deduplicates the contents of reusable-tsan.yml and reusable-ubsan.yml, making them one. The new workflow replaces the duplicated ones in the top-level build.yml and are called with different sanitizer parameters.

It is based on Hugo's patch. Context:

  • CI should run Undefined Behavior Sanitizer (UBSAN), as already done for ASAN #111758 (comment)
  • gh-111758: Run UBSan in GitHub Actions #135578 (review)
  • Issue: CI should run Undefined Behavior Sanitizer (UBSAN), as already done for ASAN #111758

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-app bedevere-app Bot mentioned this pull request Jul 19, 2025
CI should run Undefined Behavior Sanitizer (UBSAN), as already done for ASAN #111758
Closed
@StanFromIreland StanFromIreland added the skip news label Jul 19, 2025
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/reusable-ubsan.yml

@webknjaz webknjaz Jul 19, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Prior to this PR, this workflow wasn't contributing to the branch protection status. Once it's merged, it'll fail the PRs if something crashes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/reusable-san.yml Outdated
build-tsan-reusable:
name: 'Thread sanitizer'
build-san-reusable:
name: ${{ inputs.sanitizer }}

@webknjaz webknjaz Jul 19, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion w/ Hugo, this needs to mention the FT flag.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
webknjaz
webknjaz commented Jul 19, 2025
View reviewed changes
Comment thread .github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz
webknjaz force-pushed the maintenance/111758-gha-combined-san branch 2 times, most recently from 8592567 to 115b8e3 Compare July 20, 2025 09:33
hugovk and others added 2 commits July 20, 2025 12:51
@hugovk @webknjaz
Merge reusable-tsan.yml and reusable-ubsan.yml
8332820 
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
@webknjaz
Merge TSan and UBSan CI matrices
219e287
@webknjaz
webknjaz force-pushed the maintenance/111758-gha-combined-san branch from 115b8e3 to 219e287 Compare July 20, 2025 10:51
@webknjaz
webknjaz marked this pull request as ready for review July 20, 2025 12:21
@webknjaz
webknjaz requested review from AA-Turner, ezio-melotti and hugovk as code owners July 20, 2025 12:21
@bedevere-app bedevere-app Bot added the awaiting review label Jul 20, 2025
hugovk
hugovk reviewed Jul 20, 2025
View reviewed changes
Comment thread .github/workflows/reusable-san.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz @hugovk
Expand "free-threading" in the job label
50413d4 
Co-authored-by: Hugo van Kemenade <[email protected]>
@webknjaz
webknjaz requested a review from hugovk July 20, 2025 17:19
@webknjaz

webknjaz commented Jul 20, 2025

Copy link
Copy Markdown
Member Author

@hugovk I think this needs backport labels to keep the CI in other branches close.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 20, 2025
hugovk
hugovk approved these changes Jul 20, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this also nicely groups the jobs under a single collapsible thingy 👍

Before:

image

and:

image

After:

image

and:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 20, 2025
@hugovk
hugovk merged commit 65d2c51 into python:main Jul 20, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2025

Copy link
Copy Markdown

Thanks @webknjaz for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2025
@webknjaz @hugovk @miss-islington
pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (pythonG…
1e3d1a8 
…H-136820)

(cherry picked from commit 65d2c51)

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2025

Copy link
Copy Markdown

Sorry, @webknjaz and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 65d2c51c10425dcfacc0a13810d58c41240d7ff9 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Jul 20, 2025
@bedevere-app

bedevere-app Bot commented Jul 20, 2025

Copy link
Copy Markdown

GH-136883 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 20, 2025
hugovk added a commit that referenced this pull request Jul 20, 2025
@miss-islington @webknjaz @hugovk
[3.14] GH-111758: Merge TSan and UBSan reusable GHA workflows (GH-136820
2f7684c 
) (#136883)

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk

hugovk commented Jul 20, 2025

Copy link
Copy Markdown
Member

@hugovk I think this needs backport labels to keep the CI in other branches close.

Hmm, we didn't have UBSan in the 3.14 branch yet. I'm fine with having it there (and 3.13), but also to revert #136883 if it's not necessary to backport.

@encukou Should we have this just in main, or also backport?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz

webknjaz commented Jul 20, 2025

Copy link
Copy Markdown
Member Author

but also to revert #136883 if it's not necessary to backport.

I'd suggest reverting partially if needed, but the job grouping and generalization are good to keep.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added the sprint label Jul 20, 2025
@encukou

encukou commented Jul 21, 2025

Copy link
Copy Markdown
Member

@hugovk ultimately up to you, but, if it works on 3.14 I think we should keep it working.
Not on 3.13 though -- we'd need to backport #111178 to make UBSan pass.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 23, 2025
@webknjaz @hugovk
[3.13] pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (p…
8876f0a 
…ython#136820)

(cherry picked from commit 65d2c51)

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz added a commit to webknjaz/cpython that referenced this pull request Jul 23, 2025
@webknjaz @hugovk
[3.13] pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (p…
96da074 
…ython#136820)

(cherry picked from commit 65d2c51)

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
@webknjaz webknjaz mentioned this pull request Jul 23, 2025
[3.13] GH-111758: Merge TSan and UBSan reusable GHA workflows (#136820) #137029
Merged
@bedevere-app

bedevere-app Bot commented Jul 23, 2025

Copy link
Copy Markdown

GH-137029 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 23, 2025
encukou pushed a commit that referenced this pull request Aug 1, 2025
@webknjaz @hugovk
[3.13] GH-111758: Merge TSan and UBSan reusable GHA workflows (#136820)…
6a217ce 
… (GH-137029)

(cherry picked from commit 65d2c51)

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@webknjaz @hugovk @taegyunkim
pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (python#…
ad8bc56 
…136820)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@webknjaz @hugovk @Agent-Hellboy
pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (python#…
a14be76 
…136820)

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @webknjaz
@hugovk @kumaraditya303
[3.14] pythonGH-111758: Merge TSan and UBSan reusable GHA workflows (p…
f740369 
…ythonGH-136820) (python#136883)

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@thesamesam thesamesam mentioned this pull request Apr 6, 2026
gh-148286: Fail on new UB in CI #148168
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@webknjaz @hugovk @encukou @AA-Turner @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.