GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (GH-136893) by miss-islington · Pull Request #136960 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

An interesting hack, but more localized in scope than GH-135230.

This may be a breaking change if people intentionally keep the original class around
when using @dataclass(slots=True), and then use __dict__ or __weakref__ on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra [email protected]
Co-authored-by: Alyssa Coghlan [email protected]

  • Issue: 3.14 regression: slot dataclasses classes leak original class #135228

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JelleZijlstra @ncoghlan @miss-islington
pythongh-135228: When @DataClass(slots=True) replaces a dataclass, ma…
c6fde2d
…ke the original class collectible (pythonGH-136893)

An interesting hack, but more localized in scope than pythonGH-135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
@miss-islington
miss-islington requested a review from ericvsmith as a code owner July 22, 2025 04:43
@bedevere-app bedevere-app Bot added the awaiting review label Jul 22, 2025
This was referenced Jul 22, 2025
3.14 regression: slot dataclasses classes leak original class #135228
Closed
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible #136893
Merged
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) July 22, 2025 04:44
@JelleZijlstra
JelleZijlstra merged commit 6e1b31b into python:3.14 Jul 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jul 22, 2025
@JelleZijlstra JelleZijlstra mentioned this pull request Jul 22, 2025
[3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… #137013
Merged
@bedevere-app

bedevere-app Bot commented Jul 22, 2025

Copy link
Copy Markdown

GH-137013 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull request Jul 22, 2025
@JelleZijlstra
[3.14] Revert "[3.14] pythongh-135228: When @DataClass(slots=True) re…
58b43b2
…places a dataclass, make the original class collectible (pythonGH-136893) (python#136960)"

This reverts commit 6e1b31b.

Modifying the `__dict__` is likely to cause crashes
@hugovk

hugovk commented Jul 22, 2025

Copy link
Copy Markdown
Member

Reverted in #137013.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @JelleZijlstra
@ncoghlan @kumaraditya303
[3.14] pythongh-135228: When @DataClass(slots=True) replaces a datacl…
5008e85
…ass, make the original class collectible (pythonGH-136893) (python#136960)

pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (pythonGH-136893)

An interesting hack, but more localized in scope than pythonGH-135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>
@miss-islington
miss-islington deleted the backport-46cbdf9-3.14 branch January 2, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @hugovk @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.