GeezerVison

Copy link

Copy Markdown

Member

JelleZijlstra requested a review from ericvsmith as a code owner July 20, 2025 23:59

ncoghlan approved these changes Jul 22, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra commented Jul 22, 2025

View reviewed changes

…ke the original class collectible (pythonGH-136893)

An interesting hack, but more localized in scope than pythonGH-135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>

JelleZijlstra deleted the hackweakref branch July 22, 2025 04:51

…ake the original class collectible (GH-136893) (#136960)

gh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (GH-136893)

An interesting hack, but more localized in scope than GH-135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra
<[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

…places a dataclass, make the original class collectible (pythonGH-136893) (python#136960)"

This reverts commit 6e1b31b.

Modifying the `__dict__` is likely to cause crashes

…lass, make the original class collectible (python#136893)"

This reverts commit 46cbdf9.

…make the original class collectible (#136893)" (#137014)

This reverts commit 46cbdf9.

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

…ke the original class collectible (python#136893)

An interesting hack, but more localized in scope than python#135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.

Co-authored-by: Alyssa Coghlan <[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

* Fix slotted reference cycles on 3.14

Ref python/cpython#136893 &
python/cpython#135228

Co-authored-by: Jelle Zijlstra <[email protected]>

* Add news fragment

* Bump version tag to CMA

Co-authored-by: Brandt Bucher
<[email protected]>
Co-authored-by: Jelle Zijlstra
<[email protected]>

* Apply review comment

#1446 (comment)

* EAFP

---------

Co-authored-by: Jelle Zijlstra <[email protected]>

…ke the original class collectible (python#136893)

An interesting hack, but more localized in scope than python#135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.

Co-authored-by: Alyssa Coghlan <[email protected]>

…lass, make the original class collectible (python#136893)" (python#137014)

This reverts commit 46cbdf9.

…ke the original class collectible (python#136893)

An interesting hack, but more localized in scope than python#135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.

Co-authored-by: Alyssa Coghlan <[email protected]>

…lass, make the original class collectible (python#136893)" (python#137014)

This reverts commit 46cbdf9.

…ass, make the original class collectible (pythonGH-136893) (python#136960)

pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (pythonGH-136893)

An interesting hack, but more localized in scope than pythonGH-135230.

This may be a breaking change if people intentionally keep the original class around
when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the
original class.
(cherry picked from commit 46cbdf9)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Alyssa Coghlan <[email protected]>