GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" by JelleZijlstra · Pull Request #137014 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Jul 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 46cbdf9.

  • Issue: 3.14 regression: slot dataclasses classes leak original class #135228

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
Revert "pythongh-135228: When @DataClass(slots=True) replaces a datac…
7a083f3 
…lass, make the original class collectible (python#136893)"

This reverts commit 46cbdf9.
@JelleZijlstra
JelleZijlstra requested a review from ericvsmith as a code owner July 22, 2025 16:00
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2025
3.14 regression: slot dataclasses classes leak original class #135228
Closed
@JelleZijlstra
JelleZijlstra merged commit 6a285f9 into python:main Jul 23, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 23, 2025
@JelleZijlstra
JelleZijlstra deleted the back-to-leaking branch July 23, 2025 15:13
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@JelleZijlstra @taegyunkim
Revert "pythongh-135228: When @DataClass(slots=True) replaces a datac…
9df2cfe 
…lass, make the original class collectible (python#136893)" (python#137014)

This reverts commit 46cbdf9.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@JelleZijlstra @Agent-Hellboy
Revert "pythongh-135228: When @DataClass(slots=True) replaces a datac…
b41a7bd 
…lass, make the original class collectible (python#136893)" (python#137014)

This reverts commit 46cbdf9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.