GeezerVison

Hrm. The "AWS-LC" build failure seems to relate to it not finding the function SSL_CTX_set1_client_sigalgs_list. However, I don't see any sign of that only being in more recent OpenSSL releases. Is there something unusual about the version of OpenSSL used there?

Ah - I see AWS-LC combines code from BoringSSL and OpenSSL. I guess we'll need to find some way to detect AWS-LC and raise an exception if the call to set the client sigalgs is used, at least for whatever version of AWS-LC triggered this failure.

I looked through the AWS-LC code and can confirm it doesn't appear to support SSL_CTX_set1_client_sigalgs_list, even in the latest version. However, I'm not really sure how in the code to test for AWS-LC at build time or run time (either in the main SSL module or in the unit tests). I found some references claiming OPENSSL_IS_AWSLC should exist as a preprocessor symbol, but I don't see any evidence of that being used in CPython at the moment.

I decided to go ahead and code up an ssl.get_sigalgs() function which looks like the following:

>>> import ssl
>>> ssl.get_sigalgs()
['ecdsa_secp256r1_sha256', 'ecdsa_secp384r1_sha384', 'ecdsa_secp521r1_sha512',
 'ed25519', 'ed448', 'ecdsa_sha224', 'ecdsa_sha1', 'ecdsa_brainpoolP256r1tls13_sha256',
 'ecdsa_brainpoolP384r1tls13_sha384', 'ecdsa_brainpoolP512r1tls13_sha512', 'rsa_pss_rsae_sha256',
 'rsa_pss_rsae_sha384', 'rsa_pss_rsae_sha512', 'rsa_pss_pss_sha256', 'rsa_pss_pss_sha384',
 'rsa_pss_pss_sha512', 'rsa_pkcs1_sha256', 'rsa_pkcs1_sha384', 'rsa_pkcs1_sha512', 'rsa_pkcs1_sha224',
 'rsa_pkcs1_sha1', 'dsa_sha256', 'dsa_sha384', 'dsa_sha512', 'dsa_sha224', 'dsa_sha1']

It's not checked in yet, but I can do so if we decide to include it, at which point I'll go back and fill in docs and unit tests for it. It seems like it might be useful for a client/server to know the available signature algorithms that it can choose from, since it may vary depending on the OpenSSL implementation in use and what providers are loaded.

Like SSLContext.get_groups(), this method returns a list of strings. The only difference is that this is a global list of available signature algs dependent only on which OpenSSL providers are loaded, rather than being sensitive to state in the SSLContext such as the TLS min & max versions. That's why it ends up being a module-level function.

Is there something unusual about the version of OpenSSL used there?

As you observed, AWS-LC is a fork of BoringSSL & LibreSSL. We decided to try supporting other flavors of libssl implementations because it might come handy for some users that don't want to use OpenSSL.

I looked through the AWS-LC code and can confirm it doesn't appear to support SSL_CTX_set1_client_sigalgs_list, even in the latest version

If this is the case, I suggest one of the following to do:

• Fix this upstream or collaborate with @WillChilds-Klein on this matter.
• Detect at configure time whether this is supported or not by the host.
• Use OPENSSL_IS_AWSLC as claimed. We don't use it currently because everything seems to work on all ssl implementations. If something is specific to OpenSSL, then I would suggest using this macro.

If this is the case, I suggest one of the following to do:

• Fix this upstream or collaborate with @WillChilds-Klein on this matter.
• Detect at configure time whether this is supported or not by the host.
• Use OPENSSL_IS_AWSLC as claimed. We don't use it currently because everything seems to work on all ssl implementations. If something is specific to OpenSSL, then I would suggest using this macro.

I was able to get OPENSSL_IS_AWSLC to work here. I used that in the SSL module and then used the following in the unit tests (with skipUnless):

CAN_SET_CLIENT_SIGALGS = "AWS-LC" not in ssl.OPENSSL_VERSION

With that, the tests are all passing.

@picnixz, any thoughts on the proposed ssl.get_sigalgs() function? Should I go ahead and finish the work on that?

I had some time this weekend, so I've gone ahead and added support for ssl.get_sigalgs() to return a list of all available TLS signature algorithms in commit 2d47a6c. I've also updated issue #138252 to mention this function.

The failure here appears to be in whatsnew/3.15.pst not being able to see the new ssl.get_sigalgs function. That file has no problem seeing other things from the SSL module, though. Also, other documentation files seem to have no issue with it.

Any idea what might be happening here? Do I need an explicit import somewhere? I don't see any such thing for other module references in whatsnew.

@picnixz, Anything further you'd like me to change? I think I've covered all the current review comments.

No I think we're good. I'll have a final check tomorrow, and if needed, directly commit to your branch, and then merge it.

Would it be possible to mention the OpenSSL version requirements in the documentation?

That's what I plan to do (I'm actually working on it now): #138633.