GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-137242: Allow Android testbed to take all Python command-line options by mhsmith · Pull Request #138805 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#138649 and python/buildmaster-config#628 switched GitHub Actions and the buildbots over to using --fast-ci and --slow-ci on Android. However, this has introduced a warning, which has turned the buildbots orange:

Warning -- Failed to change Python options: FileNotFoundError(2, 'No such file or directory')
Warning -- Command: -u -W error -bb --dont-add-python-opts

Android runs the tests embedded in a larger app, so it's not possible to change the Python options by calling execv. Instead, this PR adds the ability to pass all Python command-line options to the Android testbed, so the options can be set to the expected values from the start.

This may also be useful in cibuildwheel, as it'll allow the testbed to accept a wider range of Python test commands (pypa/cibuildwheel#2590).

  • Issue: Android CI and binary releases #137242

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Allow Android testbed to take all Python command-line options
d07dbb8
@mhsmith
mhsmith requested a review from freakboy3742 as a code owner September 11, 2025 19:57
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2025
Android CI and binary releases #137242
Closed
@mhsmith mhsmith added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 11, 2025
This was referenced Sep 11, 2025
Make Android streams respect the unbuffered (-u) option #138806
Merged
Update Android test-command handling pypa/cibuildwheel#2590
Merged
emmatyping
emmatyping reviewed Sep 11, 2025
View reviewed changes
Comment thread Android/android.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 requested changes Sep 18, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly makes sense; a couple of minor clarification questions inline.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Sep 18, 2025
@bedevere-app

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith mhsmith mentioned this pull request Sep 19, 2025
gh-138171: Migrate iOS testbed location and add Apple build script #138176
Merged
@mhsmith
Don't attempt to re-execute Python when there is no Python executable
b680f0e
@mhsmith

mhsmith commented Sep 27, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Sep 27, 2025
@bedevere-app

bedevere-app Bot commented Sep 27, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from freakboy3742 September 27, 2025 16:17
freakboy3742
freakboy3742 requested changes Sep 29, 2025
View reviewed changes
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/libregrtest/main.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting change review labels Sep 29, 2025
@bedevere-app

bedevere-app Bot commented Sep 29, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhsmith added 2 commits October 4, 2025 16:10
@mhsmith
Add --fast-ci and --slow-ci as options of test and ci subcomm…
1fd81f9 
…ands
@mhsmith
Only add -W error if the user didn't specify a warnings policy
4ccecad
@mhsmith
mhsmith requested review from AA-Turner, ezio-melotti and hugovk as code owners October 4, 2025 15:33
@mhsmith

mhsmith commented Oct 4, 2025

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Oct 4, 2025
@bedevere-app

bedevere-app Bot commented Oct 4, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app
bedevere-app Bot requested a review from freakboy3742 October 4, 2025 15:44
freakboy3742
freakboy3742 approved these changes Oct 6, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for those changes (and explanations) - looks like a solid set of improvements.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Oct 6, 2025
@freakboy3742
freakboy3742 merged commit a9b0506 into python:main Oct 6, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 6, 2025

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@mhsmith @miss-islington
pythongh-137242: Allow Android testbed to take all Python command-lin…
41e76c0 
…e options (pythonGH-138805)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@mhsmith @miss-islington
pythongh-137242: Allow Android testbed to take all Python command-lin…
99b370d 
…e options (pythonGH-138805)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 6, 2025

Copy link
Copy Markdown

GH-139637 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 6, 2025
@bedevere-app

bedevere-app Bot commented Oct 6, 2025

Copy link
Copy Markdown

GH-139638 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 6, 2025
freakboy3742 pushed a commit that referenced this pull request Oct 6, 2025
@miss-islington @mhsmith
[3.13] gh-137242: Allow Android testbed to take all Python command-li…
d3a4e06 
…ne options (GH-138805) (#139638)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
(cherry picked from commit a9b0506)

Co-authored-by: Malcolm Smith <[email protected]>
hugovk pushed a commit that referenced this pull request Oct 6, 2025
@miss-islington @mhsmith
[3.14] gh-137242: Allow Android testbed to take all Python command-li…
f776254 
…ne options (GH-138805) (#139637)

Co-authored-by: Malcolm Smith <[email protected]>
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@mhsmith @danigm
pythongh-137242: Allow Android testbed to take all Python command-lin…
8708286 
…e options (python#138805)

Modifies the Android test runner to ensure that all valid Python command line
options are preserved when running the test suite.
@mhsmith mhsmith mentioned this pull request Oct 7, 2025
Add --fast-ci to android.py command line python/release-tools#284
Merged
@mhsmith mhsmith mentioned this pull request Oct 15, 2025
Update Android test arguments python/buildmaster-config#638
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping left review comments
@picnixz picnixz picnixz left review comments
@freakboy3742 freakboy3742 freakboy3742 approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mhsmith @freakboy3742 @emmatyping @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.