GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make Android streams respect the unbuffered (`-u`) option by mhsmith · Pull Request #138806 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Sep 11, 2025

Copy link
Copy Markdown
Member

While working on #138805, I updated the Android stream tests to be compatible with unbuffered mode. However, this mode isn't very readable on Android, because it causes lines to be split into multiple log messages. So the Android CI and buildbots are still not using unbuffered mode, but we might as well be compatible with it anyway.

I'm putting this in a separate PR from #138805 because neither change depends on the other.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Make Android streams respect the -u option
7aa2714
@mhsmith
mhsmith requested a review from freakboy3742 as a code owner September 11, 2025 20:05
@mhsmith mhsmith added skip issue skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 11, 2025
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2025
freakboy3742
freakboy3742 approved these changes Sep 18, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that there isn't much utility in an unbuffered output streaming mode, but it doesn't hurt to support it just in case it's useful somewhere.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 18, 2025
@freakboy3742
freakboy3742 merged commit 0ac377f into python:main Sep 18, 2025
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
@mhsmith @miss-islington
Make Android streams respect the unbuffered (-u) option (pythonGH-1…
c14cc11 
…38806)

Android pipes stdout/stderr to the log, which means every write to the log
becomes a separate log line. As a result, most practical uses of stdout/stderr
should be buffered; but it doesn't hurt to preserve unbuffered handling in case
it's useful.
(cherry picked from commit 0ac377f)

Co-authored-by: Malcolm Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
@mhsmith @miss-islington
Make Android streams respect the unbuffered (-u) option (pythonGH-1…
532c59f 
…38806)

Android pipes stdout/stderr to the log, which means every write to the log
becomes a separate log line. As a result, most practical uses of stdout/stderr
should be buffered; but it doesn't hurt to preserve unbuffered handling in case
it's useful.
(cherry picked from commit 0ac377f)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139108 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
@bedevere-app

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139110 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 18, 2025
Yhg1s pushed a commit that referenced this pull request Sep 18, 2025
@miss-islington @mhsmith
[3.13] Make Android streams respect the unbuffered (-u) option (GH-…
5e59aef 
…138806) (#139110)

Android pipes stdout/stderr to the log, which means every write to the log
becomes a separate log line. As a result, most practical uses of stdout/stderr
should be buffered; but it doesn't hurt to preserve unbuffered handling in case
it's useful.
(cherry picked from commit 0ac377f)

Co-authored-by: Malcolm Smith <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 29, 2025
@miss-islington @mhsmith
[3.14] Make Android streams respect the unbuffered (-u) option (GH-…
7a65a47 
…138806) (#139108)

Co-authored-by: Malcolm Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhsmith @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.