GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92266: Update pre-commit by hugovk · Pull Request #139411 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Sep 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Tools/c-analyzer/cpython/_parser.py no longer contains tabs, remove from remove-tabs exclude: make patchcheck: Allow Tabs in Some Cases #92266 (comment)
  • Update to latest repo versions
  • Don't ignore UP038, the rule has been removed and ignoring has no effect: https://astral.sh/blog/ruff-v0.13.0#rule-removals
  • Rename legacy ruff ID to ruff-check: https://github.com/astral-sh/ruff-pre-commit/blob/f298305809c552671cc47e0fec0ba43e96c146a2/.pre-commit-hooks.yaml#L25
  • Issue: make patchcheck: Allow Tabs in Some Cases #92266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 4 commits September 29, 2025 11:36
@hugovk
_parser.py no longer contains tabs
381d148
@hugovk
prek autoupdate --jobs 0
a03fb25
@hugovk
Don't ignore UP038, the rule has been removed and ignoring has no effect
1efe015
@hugovk
Rename legacy 'ruff' ID to 'ruff-check'
d5d3e02
@hugovk
hugovk requested review from AA-Turner, AlexWaygood, erlend-aasland, lysnikolaou and pablogsal as code owners September 29, 2025 08:55
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 29, 2025
@hugovk hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Sep 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 29, 2025
make patchcheck: Allow Tabs in Some Cases #92266
Closed
@AlexWaygood AlexWaygood added the skip news label Sep 29, 2025
@StanFromIreland StanFromIreland added the awaiting core review label Sep 29, 2025
itamaro
itamaro approved these changes Sep 30, 2025
View reviewed changes

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the attached issue relevant to this PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Partially, that issue was the trigger for updating because Tools/c-analyzer/cpython/_parser.py was excluded from remove-tabs and #92266 (comment) notes it no longer has tabs.

But we can also skip-issue here if you like.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@itamaro

itamaro commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

But we can also skip-issue here if you like.

Either would be fine
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 800d856 into python:main Oct 1, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the pre-commit-remove-tabs branch October 1, 2025 05:40
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 1, 2025
@miss-islington-app

miss-islington-app Bot commented Oct 1, 2025

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2025
@hugovk @miss-islington
pythongh-92266: Update pre-commit (pythonGH-139411)
bb18c88 
(cherry picked from commit 800d856)

Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Oct 1, 2025

Copy link
Copy Markdown

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 800d856bc78ec0431450361c346bc1e5996f6624 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Oct 1, 2025
@bedevere-app

bedevere-app Bot commented Oct 1, 2025

Copy link
Copy Markdown

GH-139466 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 1, 2025
hugovk added a commit that referenced this pull request Oct 8, 2025
@miss-islington @hugovk
[3.14] gh-92266: Update pre-commit (GH-139411) (#139466)
297157d 
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 8, 2025

Copy link
Copy Markdown

GH-139760 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Oct 8, 2025
hugovk added a commit to hugovk/cpython that referenced this pull request Oct 8, 2025
@hugovk
[3.13] pythongh-92266: Update pre-commit (pythonGH-139411)
fea7b7c 
(cherry picked from commit 800d856)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Oct 27, 2025
@hugovk
[3.13] gh-92266: Update pre-commit (GH-139411) (#139760)
2d29aa2 
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hugovk @itamaro @AlexWaygood @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.