GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-92266: Update pre-commit (GH-139411) by hugovk · Pull Request #139760 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 800d856)

  • Issue: make patchcheck: Allow Tabs in Some Cases #92266

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
[3.13] pythongh-92266: Update pre-commit (pythonGH-139411)
fea7b7c 
(cherry picked from commit 800d856)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2025
make patchcheck: Allow Tabs in Some Cases #92266
Closed
@bedevere-app bedevere-app Bot added the skip news label Oct 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 8, 2025
gh-92266: Update pre-commit #139411
Merged
hugovk
hugovk commented Oct 8, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml
hooks:
- id: remove-tabs
types: [python]
exclude: ^Tools/c-analyzer/cpython/_parser.py

@hugovk hugovk Oct 8, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AA-Turner Same question here: shall we backport #137622 (that removed tabs from this file), or keep this exclude for 3.13?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk commented Oct 27, 2025
View reviewed changes
Comment thread .pre-commit-config.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.
hugovk added 2 commits October 27, 2025 15:31
@hugovk
Keep the exclude
2fd5c4c
@hugovk
Backport the actionlint config
405ea01
@hugovk
hugovk marked this pull request as ready for review October 27, 2025 13:51
@hugovk
hugovk requested review from AlexWaygood, erlend-aasland, ezio-melotti, lysnikolaou and pablogsal as code owners October 27, 2025 13:51
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 27, 2025
@hugovk
hugovk merged commit 2d29aa2 into python:3.13 Oct 27, 2025
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk deleted the backport-800d856-3.13 branch October 27, 2025 14:14
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.