GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-76007: Deprecate `zlib.__version__` attribute by StanFromIreland · Pull Request #140130 · python/cpython

Conversation

StanFromIreland commented Oct 14, 2025 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Misleading __version__ attribute of modules in standard library #76007

📚 Documentation preview 📚: https://cpython-previews--140130.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Commit

dcda91a

StanFromIreland requested a review from AA-Turner as a code owner

October 14, 2025 19:29

StanFromIreland requested a review from hugovk

October 14, 2025 19:29

bedevere-app Bot mentioned this pull request

Oct 14, 2025

Misleading __version__ attribute of modules in standard library #76007

Closed

bedevere-app Bot added the awaiting review label

Oct 14, 2025

vstinner reviewed

Oct 14, 2025

View reviewed changes

Comment thread

Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Oct 14, 2025

View reviewed changes

Comment thread

Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Victor's review

4aeea1a

StanFromIreland requested a review from vstinner

October 15, 2025 06:46

StanFromIreland commented

Oct 15, 2025

View reviewed changes

Comment thread

Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Remove accidental line

37ceee0

vstinner approved these changes

Oct 15, 2025

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/zlibmodule.c

		ZLIB_CRC32_COMBINE_METHODDEF
		ZLIB_DECOMPRESS_METHODDEF
		ZLIB_DECOMPRESSOBJ_METHODDEF
		{"__getattr__", zlib_getattr, METH_VARARGS, "Module __getattr__"},

vstinner Oct 15, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to convert the function to Argument Clinic, but it failed, oh!

Error in file 'Modules/zlibmodule.c' on line 2019:
'__getattr__' is a special method and cannot be converted to Argument Clinic!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland reacted with laugh emoji

All reactions

😄 1 reaction

StanFromIreland Oct 15, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that too :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reacted with thumbs up emoji

All reactions

👍 1 reaction

merwok Oct 19, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a valid feature request for AC or it’s somehow impossible?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

StanFromIreland Oct 19, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, and it is relatively straightforward (I based my implementation on METHOD_INIT's), here is a patch. I do not know if there was a reason for this not being done before, other than there not being a need, as it is explicitly in the unsupported list, maybe Victor knows more?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Oct 19, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why it's not supported currently.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

StanFromIreland Oct 19, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the patch?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Oct 20, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can propose it as a PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland reacted with thumbs up emoji

All reactions

👍 1 reaction

StanFromIreland Oct 20, 2025

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #140376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-app Bot added awaiting merge and removed awaiting review labels

Oct 15, 2025

vstinner merged commit 46f11b3 into python:main

Oct 15, 2025

4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Oct 15, 2025

vstinner commented Oct 15, 2025

Copy link

Copy Markdown

Member

Merged, thanks. I also saw that version but forgot to deprecate it :-)

StanFromIreland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland deleted the zlib-version branch

October 15, 2025 12:21

This was referenced Oct 19, 2025

gh-76007: Deprecate __version__ attribute in decimal #140302

Merged

Support __getattr__ method in AC #140382

Closed

StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request

Dec 6, 2025


          pythongh-76007: Deprecate zlib.__version__ attribute (python#140130)

1ec053f

Reviewers

vstinner

vstinner approved these changes

merwok

merwok left review comments

AA-Turner

Awaiting requested review from AA-Turner

AA-Turner is a code owner

hugovk

Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

StanFromIreland commented Oct 14, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StanFromIreland Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Oct 15, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StanFromIreland commented Oct 14, 2025 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland Oct 19, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.