GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure by jbosboom · Pull Request #140185 · python/cpython

Conversation

@jbosboom

@jbosboom jbosboom commented Oct 16, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11. That's safe at runtime because all kernels clear the reserved space in struct statx and zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids allocating another mask bit, which are a limited resource. But it also means the kernel headers don't provide a way to check whether stx_atomic_write_unit_max_opt exists, so add a configure check.

I ran make regen-configure. I know very little about autoconf, so please check I didn't mess up.

  • Issue: Add os.statx() function #83714

📚 Documentation preview 📚: https://cpython-previews--140185.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jbosboom
Check for struct statx.stx_atomic_write_unit_max_opt in configure
37ebb56 
stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled
by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe at
runtime because all kernels clear the reserved space in struct statx and
zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids
allocating another mask bit, which are a limited resource.  But it also
means the kernel headers don't provide a way to check whether
stx_atomic_write_unit_max_opt exists, so add a configure check.
@jbosboom
jbosboom requested review from AA-Turner, corona10, emmatyping and erlend-aasland as code owners October 16, 2025 01:13
@bedevere-app bedevere-app Bot added the awaiting review label Oct 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 16, 2025
Add os.statx() function #83714
Closed
@jbosboom

jbosboom commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot AMD64 CentOS9 NoGIL 3.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

You don't have write permissions to trigger a build
jbosboom reacted with confused emoji
All reactions
  • 😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbosboom jbosboom mentioned this pull request Oct 16, 2025
gh-83714: Implement os.statx #139178
Merged
@jbosboom

jbosboom commented Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

#139178 failed on the AMD64 CentOS9 NoGIL 3.x (tier-1), ARM64 Raspbian Debug 3.x (tier-3) and ARM Raspbian 3.x (tier-3) buildbots. I need someone with the appropriate permissions to run those before merging.

This should be skip-news.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cmaloney
cmaloney reviewed Oct 16, 2025
View reviewed changes

@cmaloney cmaloney left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable approach to me; a core dev can trigger the bots to validate (although the queue can take a while to get to the top of).

I think skip news works as this is falls under "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@encukou

This comment was marked as outdated.

Sign in to view
1 similar comment
@encukou

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member

!buildbot AMD64.CentOS9.NoGIL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the skip news label Oct 16, 2025
vstinner
vstinner approved these changes Oct 16, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let me check on buildbots.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 16, 2025
@vstinner

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

!buildbot Raspbian
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 37ebb56 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140185%2Fmerge

The command will test the builders whose names match following regular expression: Raspbian

The builders matched are:

  • ARM Raspbian Linux Asan PR
  • ARM64 Raspbian Debug PR
  • ARM Raspbian PR
  • ARM64 Raspbian PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member

Buildbot issues to expect:

  • The refleak in test_type_aliases was gh-139817: Fix refleak in TypeAliasType(qualname=non_string) #140197.
  • Some workers currently have conncetion issues and will fail in test_urllib2net.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

Buildbots passed successfully:

  • buildbot/AMD64 CentOS9 NoGIL PR
  • buildbot/ARM Raspbian PR
  • buildbot/ARM64 Raspbian Debug PR
  • buildbot/ARM64 Raspbian PR

Buildbot issues to expect: The refleak in test_type_aliases was #140197.

Alright, AMD64 CentOS9 NoGIL Refleaks PR failed on an unrelated test: test_type_aliases leaked [1, 1, 1] references, sum=3.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 5a31024 into python:main Oct 16, 2025
8 of 9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 16, 2025
@vstinner

vstinner commented Oct 16, 2025

Copy link
Copy Markdown
Member

Merged, thanks @jbosboom.
cmaloney reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbosboom jbosboom mentioned this pull request Oct 21, 2025
gh-83714: Check for struct statx members in configure #140402
Merged
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@jbosboom @StanFromIreland
pythongh-83714: Check for struct statx.stx_atomic_write_unit_max_opt …
4215e46 
…in configure (python#140185)

stx_atomic_write_unit_max_opt was added in Linux 6.16, but is controlled
by the STATX_WRITE_ATOMIC mask bit added in Linux 6.11.  That's safe at
runtime because all kernels clear the reserved space in struct statx and
zero is a valid value for stx_atomic_write_unit_max_opt, and it avoids
allocating another mask bit, which are a limited resource.  But it also
means the kernel headers don't provide a way to check whether
stx_atomic_write_unit_max_opt exists, so add a configure check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmaloney cmaloney cmaloney left review comments
@vstinner vstinner vstinner approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jbosboom @bedevere-bot @encukou @vstinner @cmaloney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.