GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139817: Fix refleak in TypeAliasType(qualname=non_string) by encukou · Pull Request #140197 · python/cpython

Conversation

@encukou

@encukou encukou commented Oct 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: TypeAliasType objects have no __qualname__ #139817

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-139817: Fix refleak in TypeAliasType(qualname=non_string)
8c46640
@encukou
encukou requested a review from JelleZijlstra as a code owner October 16, 2025 08:32
@bedevere-app bedevere-app Bot mentioned this pull request Oct 16, 2025
TypeAliasType objects have no __qualname__ #139817
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 16, 2025
@encukou encukou added the skip news label Oct 16, 2025
@encukou

encukou commented Oct 16, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.Fedora.Stable.Refleaks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 8c46640 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140197%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.Fedora.Stable.Refleaks

The builders matched are:

  • AMD64 Fedora Stable Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
efimov-mikhail
efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

@efimov-mikhail efimov-mikhail left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've missed this, sorry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
efimov-mikhail
efimov-mikhail reviewed Oct 16, 2025
View reviewed changes
Comment thread Objects/typevarobject.c
Py_DECREF(module);
return NULL;
}
}

@efimov-mikhail efimov-mikhail Oct 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, it's better to place obtaining of module after qualname related if-block and remove a call of Py_DECREF(module).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@encukou
Move obtaining module
11d3641
@encukou
encukou enabled auto-merge (squash) October 16, 2025 11:00
efimov-mikhail
efimov-mikhail approved these changes Oct 16, 2025
View reviewed changes

@efimov-mikhail efimov-mikhail left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested for the refleak locally, it's gone.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
encukou merged commit ea4cc58 into python:main Oct 16, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 16, 2025
@encukou encukou mentioned this pull request Oct 16, 2025
gh-83714: Check for struct statx.stx_atomic_write_unit_max_opt in configure #140185
Merged
@encukou
encukou deleted the gh-139817-leak branch October 17, 2025 10:30
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou @StanFromIreland
pythongh-139817: Fix refleak in TypeAliasType(qualname=non_string) (p…
fe4b7b7 
…ythonGH-140197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@encukou @bedevere-bot @efimov-mikhail
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.