GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-139757: JIT: Remove redundant branches to jumps in the assembly optimizer by markshannon · Pull Request #140800 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Oct 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Refactor JIT assembly optimizer making instructions instances not just strings
  • Remove redundant jumps and branches where legal to do so
  • Issue: JIT assembly optimizer leaves some redundant branches #139757

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
markshannon requested review from brandtbucher, diegorusso and savannahostrowski as code owners October 30, 2025 16:24
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2025
JIT assembly optimizer leaves some redundant branches #139757
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2025
@markshannon
markshannon force-pushed the remove-redundant-branches branch 2 times, most recently from 4ed4522 to 26f8269 Compare October 30, 2025 18:15
@markshannon markshannon added the skip news label Oct 30, 2025
@markshannon
markshannon force-pushed the remove-redundant-branches branch from 26f8269 to 0086c59 Compare October 30, 2025 19:26
markshannon added a commit to markshannon/cpython that referenced this pull request Dec 4, 2025
@markshannon
Fix reference leaks introduced in pythonGH-140800
fa5af0d
markshannon added a commit that referenced this pull request Dec 4, 2025
@markshannon
GH-139757: Fix reference leaks introduced in GH-140800 (GH-142257)
6825d5c
@markshannon
JIT: Remove redundant branches to jump in the assembly optimizer
509f3e2 
* Refactor JIT assembly optimizer making instructions instances not just strings
* Remove redundant jumps and branches where legal to do so
* Modifies _BINARY_OP_SUBSCR_STR_INT to avoid excessive inlining depth

TEST_TEMPLATE: projects/python/templates/default
PYTHON_OPTIONS: --configure-flags "--enable-experimental-jit"

Jira: ENTLLT-8874
Change-Id: I605618c92814059bc63a1d16825a66d1824f3df2
@markshannon
markshannon force-pushed the remove-redundant-branches branch from 0086c59 to 509f3e2 Compare December 5, 2025 13:52
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2025
@bedevere-bot

bedevere-bot commented Dec 5, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 509f3e2 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140800%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 5, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@markshannon @StanFromIreland
pythonGH-139757: Fix reference leaks introduced in pythonGH-140800 (p…
f3ecc76 
…ythonGH-142257)
@markshannon

markshannon commented Dec 8, 2025

Copy link
Copy Markdown
Member Author

The android build is currently broken.
The Windows 11 refleaks PR failures seem to be in the new profiling tests, unrelated to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
diegorusso
diegorusso approved these changes Dec 8, 2025
View reviewed changes

@diegorusso diegorusso left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've already reviewed it internally.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 8, 2025
@markshannon
markshannon merged commit e0451ce into python:main Dec 8, 2025
150 of 152 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 8, 2025
@chris-eibl chris-eibl mentioned this pull request Jan 4, 2026
gh-139757: Add BINARY_OP_SUBSCR_USTR_INT #143389
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegorusso diegorusso diegorusso approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @diegorusso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.