GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-141794: Fix reference leaks introduced in GH-142228 by markshannon · Pull Request #142257 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Dec 4, 2025 •
edited by chris-eibl
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Compiling executors can result in excessively large amounts of machine code. #141794

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Fix reference leaks introduced in pythonGH-140800
fa5af0d
@bedevere-app bedevere-app Bot mentioned this pull request Dec 4, 2025
JIT assembly optimizer leaves some redundant branches #139757
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 4, 2025
@markshannon markshannon added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Dec 4, 2025
@bedevere-bot

bedevere-bot commented Dec 4, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit fa5af0d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142257%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Dec 4, 2025
@markshannon markshannon mentioned this pull request Dec 4, 2025
GH-141794: Limit size of generated machine code. #142228
Merged
diegorusso
diegorusso approved these changes Dec 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 4, 2025
@markshannon

markshannon commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

The s390x failures appear to timing related and aren't memory leaks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 6825d5c into python:main Dec 4, 2025
71 of 72 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 4, 2025
@bedevere-bot

bedevere-bot commented Dec 4, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Installed with X 3.x (no tier) has failed when building commit 6825d5c.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1244/builds/6846) and take a look at the build logs.
  4. Check if the failure is related to this commit (6825d5c) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1244/builds/6846

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.15/test/test_annotationlib.py"�[0m, line �[35m160�[0m, in �[35mtest_nonexistent_attribute�[0m
    �[31mself.assertEqual�[0m�[1;31m(epsilon_anno, support.EqualToForwardRef("some | {obj, module}", owner=f))�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;35mAssertionError�[0m: �[35mForwardRef('some | {module, obj}', owner=[79 chars]028>) != EqualToForwardRef('some | {obj, module}',[86 chars]028>)�[0m


Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.15/test/test_annotationlib.py"�[0m, line �[35m160�[0m, in �[35mtest_nonexistent_attribute�[0m
    �[31mself.assertEqual�[0m�[1;31m(epsilon_anno, support.EqualToForwardRef("some | {obj, module}", owner=f))�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;35mAssertionError�[0m: �[35mForwardRef('some | {module, obj}', owner=[79 chars]b80>) != EqualToForwardRef('some | {obj, module}',[86 chars]b80>)�[0m
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl

chris-eibl commented Dec 6, 2025

Copy link
Copy Markdown
Member

This should be linked with issue #141794 since it was introduced in the PR #142228 associated with it?

I took the liberty of doing that. Hope you don't mind.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl chris-eibl changed the title GH-139757: Fix reference leaks introduced in GH-140800 GH-139757: Fix reference leaks introduced in GH-141794 Dec 6, 2025
@chris-eibl chris-eibl changed the title GH-139757: Fix reference leaks introduced in GH-141794 GH-141794: Fix reference leaks introduced in GH-142228 Dec 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2025
Compiling executors can result in excessively large amounts of machine code. #141794
Open
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@markshannon @StanFromIreland
pythonGH-139757: Fix reference leaks introduced in pythonGH-140800 (p…
f3ecc76 
…ythonGH-142257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegorusso diegorusso diegorusso approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @bedevere-bot @chris-eibl @diegorusso
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.