GeezerVison

Some unrelated tests to get the coverage rate of _module_completer to 100% (in a separate commit, I can remove it if needed)

Could you extract those into a separate PR? I think those are nice to have in any case and we can merge it quickly :)

Could you extract those into a separate PR? I think those are nice to have in any case and we can merge it quickly :)

Sure, #143244

Quick initial question, can we disable the prompt for stdlib modules? I don't think there should be any concerns with auto-importing from the stdlib

We could, yes. I don't think we can decide to auto-import solely on module name (to take care of potential shadowing by first/third-party modules), so we would need to look the module spec location, but since we already have self._is_stdlib_module and self._global_cache that should be easy and fast!

(I'll won't be to get my hands on the code until early January tho)

Yup, we definitely need to look at the module location, not just the name

The new test is quite platform-dependant (I just fixed an iOS + Andoid only fail), it may be a good idea to trigger buildbots on this PR!

Thanks!

trigger buildbots on this PR

I can run the buildbots, do you want them now?

I can run the buildbots, do you want them now?

Yes please! I don't plan any more change on my side.

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 9c80367 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140871%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Okay that was useful, buildbot failures analysis:

• A lot of fails on compression.ztsd not suggestingcompress attribute, which is expected since it is an optional module, I'll use a better test case 😅
• All Reafleaks buildbots fail on collections.abc not suggesting Buffer, I don't know why but I suppose it's expected too, I'll use another test case
• iOS ARM64 Simulator has a lot of other fails, I don't quite understand what's going on 🤔
  • maybe an importer cache issue like last time? I'll add some invalidation

AMD64 Debian root PR
AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
AMD64 RHEL8 LTO + PGO PR
AMD64 RHEL8 LTO PR
AMD64 RHEL8 PR
AMD64 RHEL8 Refleaks PR
AMD64 Ubuntu Shared PR
ARM64 MacOS M1 NoGIL PR
ARM64 MacOS M1 Refleaks NoGIL PR
ARM64 Raspbian Debug PR
ARM64 Raspbian PR
PPC64LE RHEL8 LTO + PGO PR
PPC64LE RHEL8 LTO PR
PPC64LE RHEL8 PR
PPC64LE RHEL8 Refleaks PR
s390x Fedora Stable Clang Installed PR
s390x Fedora Stable Clang PR
s390x Fedora Stable LTO + PGO PR
s390x Fedora Stable LTO PR
s390x Fedora Stable PR
s390x Fedora Stable Refleaks PR
s390x RHEL8 LTO + PGO PR
s390x RHEL8 LTO PR
s390x RHEL8 PR
s390x RHEL8 Refleaks PR
s390x RHEL9 LTO + PGO PR
s390x RHEL9 LTO PR
s390x RHEL9 PR
s390x RHEL9 Refleaks PR
x86-64 MacOS Intel ASAN NoGIL PR
x86-64 MacOS Intel NoGIL PR

Missing AMD64 CentOS9 NoGIL Refleaks PR
AMD64 FreeBSD Refleaks PR
AMD64 RHEL8 Refleaks PR
ARM64 MacOS M1 Refleaks NoGIL PR
PPC64LE RHEL8 Refleaks PR
s390x Fedora Stable Refleaks PR
s390x RHEL8 Refleaks PR
s390x RHEL9 Refleaks PR

iOS ARM64 Simulator PR

@StanFromIreland if you could trigger a builbots run again, that would be great! Thanks

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit da6cf7f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140871%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Ok, good news: iOS Siumlator is green!

Bad news: all Refleaks builds now fail ~all attribute completion tests 😞

Good news: I reproduced in local (python -m test pass, -m test -R: fails), on it!

That check fail doesn't look related to this PR (Error: The template is not valid. .github/workflows/build.yml (Line: 720, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.)

Refleak tests pass locally, may I ask for a last run with 🔨 test-with-refleak-buildbots @StanFromIreland, just to be sure? Thanks a lot!

That check fail doesn't look related to this PR (Error: The template is not valid. .github/workflows/build.yml (Line: 720, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.)

However, it is. You need to update the branch, the current version is incompatible with our CI.

Thanks a lot @loic-simon! I made a small commit fixing a bunch of small things and adding fixes for edge cases and related test cleanups. I also rebased the branch onto the latest main and reran the relevant smoke/tests locally.

With this I am happy to land :)

Thanks a lot Pablo! If don't want to abuse your time, but while you have PyREPL import suggestions in mind, I have this one-line bugfix PR that could use a merge too 😄

Thanks a lot Pablo! If don't want to abuse your time, but while you have PyREPL import suggestions in mind, I have this one-line bugfix PR that could use a merge too 😄

Landed! Thank you for your time :)

Heh, of course these two would conflict 😅 fixing it

Thanks a lot for your contribution @loic-simon 🚀