GeezerVison is showing github.com — gh-69605: Add math.integer to PyREPL module completer hardcoded list by loic-simon · Pull Request #144811 · python/cpython
Conversation
loic-simon
commented
Feb 13, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add the new math.integer submodule to the hardcoded list of stdlib modules that cannot be detected by pkgutil (implemented in #138268).
See this DPO post for more context about why this is necessary in the first place. I also talk about a new test to ensure this list doesn't get more out of sync, but it builds on the work I did in #140871 (to ensure we don't import a "dangerous" module), so I'll propose it after that MR is merged.
I don't think this change needs a specific issue, but happy to do create one if needed!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
johnslavik
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thing!
Personally, I'd add a news entry. math.integer is a 3.15+ module and your first change also lives in 3.14. To me, it makes sense to record what was added where.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
loic-simon reacted with thumbs up emoji
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
Reviewers
lysnikolaou
Awaiting requested review from lysnikolaou
lysnikolaou is a code owner
ambv
Awaiting requested review from ambv
ambv is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.