GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142466: Pixi package definitions for downstream use by lucascolley · Pull Request #142469 · python/cpython

Conversation

@lucascolley

@lucascolley lucascolley commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

implementation for gh-142466, supporting numpy/numpy#30381 and scipy/scipy#24066.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

wolfv, FFY00, and Hofer-Julian reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
lucascolley added 2 commits December 5, 2025 22:43
@lucascolley
WIP: ENH: Pixi package definitions for downstream development
375594b
[skip ci]
@lucascolley
linux-64 support
54274f2
@bedevere-app

bedevere-app Bot commented Dec 9, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@python-cla-bot

python-cla-bot Bot commented Dec 9, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot mentioned this pull request Dec 9, 2025
Add pixi definitions for building with the address sanitizer #142466
Closed
lucascolley
lucascolley commented Dec 9, 2025
View reviewed changes
Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread .gitignore Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/build.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/build.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/build.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lucascolley lucascolley mentioned this pull request Dec 9, 2025
Feature: Add guide to install system dependencies with Pixi python/devguide#1669
Open
@lucascolley
lucascolley marked this pull request as ready for review December 9, 2025 15:27
@bedevere-app bedevere-app Bot added the awaiting review label Dec 9, 2025
@lucascolley

lucascolley commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

ping @FFY00 @hugovk @lysnikolaou

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland StanFromIreland added the skip news label Dec 9, 2025
StanFromIreland
StanFromIreland reviewed Dec 9, 2025
View reviewed changes
Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland

StanFromIreland commented Dec 9, 2025

Copy link
Copy Markdown
Member

You need to update the branch to fix the CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lucascolley
Merge branch 'main' into pixi-build
67cd009
lucascolley
lucascolley commented Dec 9, 2025
View reviewed changes
Comment thread Tools/pixi-packages/build.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

lucascolley added 4 commits December 9, 2025 20:08
@lucascolley
tidy gitignore
6c47ff1
@lucascolley
respond to review
ad7a35f
- switch cases on `PYTHON_VARIANT`
- remove `minor_version` by using `python3`
- remove runtime-only asan options
@lucascolley
README updates
b49095c
@lucascolley
use .md to preview rendering
4d0983e
StanFromIreland
StanFromIreland reviewed Dec 9, 2025
View reviewed changes
Comment thread Tools/pixi-packages/README Resolved

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk reviewed Dec 10, 2025
View reviewed changes
Comment thread Tools/README Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/README.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/asan/recipe.yaml Outdated
@@ -0,0 +1,65 @@
context:
# XXX: keep up to date

@hugovk hugovk Dec 10, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: https://discuss.python.org/t/cryptic-sequences-in-comments/38694

Can we replace all the "XXX" with "TODO" or something else? Maybe we don't even need it here:

Suggested change
# XXX: keep up to date
# Keep up to date

If we do merge this, we have code in https://github.com/python/release-tools which is run during the first beta, when main becomes the next version, that updates a bunch of versions in the repo. And we can later update that to also update these versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@lucascolley lucascolley Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://rattler-build.prefix.dev/latest/experimental_features/#load_from_filefile_path may remove the need for this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@lucascolley lucascolley Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a YAML, TOML, or JSON file that contains the version @hugovk ? If not, could we add one?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hugovk hugovk Dec 10, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't. Yes we can add one, it removes duplication here, and will be easier to programmatically update such a file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lucascolley reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@lucascolley lucascolley Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any preference for format / location / name?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hugovk hugovk Dec 17, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this because it was marked as resolved but I don't think it has been :)

Format: TOML or JSON, we can read using the stdlib.

Location: Tools/pixi-packages/, or Tools/ so other scripts can re-use it.

Name: Hmm, python-version.[ext] ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@lucascolley lucascolley Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was resolved for this PR via the third paragraph of #142469 (review)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@hugovk hugovk Dec 17, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Tools/pixi-packages/default/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tools/pixi-packages/default/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lucascolley @hugovk
Apply suggestions from code review
453e9ee
Co-authored-by: Hugo van Kemenade <[email protected]>
This was referenced Dec 10, 2025
BLD/DEV: ASAN at your fingertips! scipy/scipy#24066
Merged
ENH: Pixi package definitions for downstream development numpy/numpy#30381
Merged
FFY00
FFY00 reviewed Dec 10, 2025
View reviewed changes
Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

FFY00
FFY00 reviewed Dec 10, 2025
View reviewed changes
Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

FFY00
FFY00 reviewed Dec 10, 2025
View reviewed changes
Comment thread Tools/pixi-packages/default/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

FFY00
FFY00 reviewed Dec 10, 2025
View reviewed changes
Comment thread Tools/pixi-packages/default/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

lucascolley and others added 2 commits December 10, 2025 17:45
@lucascolley @FFY00
Apply suggestion from @FFY00
21353f2
Co-authored-by: Filipe Laíns <[email protected]>
@lucascolley @FFY00
Apply suggestion from @FFY00
c437bc3
Co-authored-by: Filipe Laíns <[email protected]>
@lucascolley @FFY00
Apply suggestion from @FFY00
d3566a5
Co-authored-by: Filipe Laíns <[email protected]>
lucascolley
lucascolley commented Dec 10, 2025
View reviewed changes
Comment thread Tools/pixi-packages/asan/recipe.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lucascolley
Apply suggestion from @lucascolley
9c811e9
FFY00
FFY00 approved these changes Dec 10, 2025
View reviewed changes

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on this @lucascolley! This is PR looks great, and sets up to add other sanitizer variants.

The pixi limitation that requires us to have separate recipes for each variant (prefix-dev/pixi#4599) is unfortunate, but I think doable from a maintenance POV, given that we have a few people interested in this. We'll see how it translates in practice, and hope the feature request gets implemented in the meantime.

I opened prefix-dev/rattler-build#2047 regarding the version string that currently needs to be updated manually, but could be dirtermined from git, with additional information. But let's wait for the pixi jinja functions to get stabilized before adding them to our recipes.

I'll leave this PR open a couple days to give a bit more time for folks to give feedback, but otherwise, this looks good to go 😊

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lucascolley reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 10, 2025
@lucascolley
lucascolley requested a review from FFY00 December 15, 2025 14:44
@FFY00

FFY00 commented Dec 15, 2025

Copy link
Copy Markdown
Member

Looks like nobody raised any issues 😊

Congrats @lucascolley!

lucascolley reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@FFY00
FFY00 merged commit 8bb5b6e into python:main Dec 15, 2025
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 15, 2025
@lucascolley

lucascolley commented Dec 15, 2025

Copy link
Copy Markdown
Contributor Author

thanks a lot Filipe!

FFY00 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 16, 2025
@lucascolley @hugovk
@FFY00 @fatelei
pythongh-142466: Pixi package definitions for downstream use (python#…
9981061
…142469)

* WIP: ENH: Pixi package definitions for downstream development

[skip ci]

* linux-64 support

* tidy gitignore

* respond to review
- switch cases on `PYTHON_VARIANT`
- remove `minor_version` by using `python3`
- remove runtime-only asan options

* README updates

* use `.md` to preview rendering

* Apply suggestions from code review

Co-authored-by: Hugo van Kemenade <[email protected]>

* Apply suggestion from @FFY00

Co-authored-by: Filipe Laíns <[email protected]>

* Apply suggestion from @FFY00

Co-authored-by: Filipe Laíns <[email protected]>

* Apply suggestion from @FFY00

Co-authored-by: Filipe Laíns <[email protected]>

* Apply suggestion from @lucascolley

---------

Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Filipe Laíns <[email protected]>
This was referenced Dec 17, 2025
gh-143120: pixi builds for free-threading and TSAN #142872
Merged
pixi definitions fail with pypi-dependencies #142897
Closed
@lucascolley
lucascolley deleted the pixi-build branch December 19, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@ngoldbaum ngoldbaum ngoldbaum left review comments
@StanFromIreland StanFromIreland StanFromIreland left review comments
@FFY00 FFY00 Awaiting requested review from FFY00

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@lucascolley @StanFromIreland @FFY00 @hugovk @ngoldbaum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.