GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-142890: remove unnecessary interp parameter from dict functions and `_PyDict_NotifyEvent` by kumaraditya303 · Pull Request #142923 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Dec 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Many functions in dictobject.c take a PyInterpreterState *interp parameter, but none of them use it. #142890

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
remove unnecessary interp usage
da14e12
@kumaraditya303
kumaraditya303 requested review from markshannon and methane as code owners December 18, 2025 07:17
@kumaraditya303 kumaraditya303 added the skip news label Dec 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 18, 2025
Many functions in dictobject.c take a PyInterpreterState *interp parameter, but none of them use it. #142890
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Dec 18, 2025
ZeroIntensity
ZeroIntensity approved these changes Dec 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 18, 2025
@kumaraditya303
kumaraditya303 merged commit e22c495 into python:main Dec 18, 2025
76 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 18, 2025
@kumaraditya303
kumaraditya303 deleted the cleanup-dict branch December 18, 2025 17:19
cocolato pushed a commit to cocolato/cpython that referenced this pull request Dec 18, 2025
@kumaraditya303 @cocolato
pythongh-142890: remove unnecessary interp parameter from dict functi…
3c0a6c4 
…ons and `_PyDict_NotifyEvent` (python#142923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.