GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143148: Replace pre-commit with prek in CI by juhannc · Pull Request #143149 · python/cpython

Conversation

@juhannc

@juhannc juhannc commented Dec 24, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #143148

  • Issue: Replace pre-commit with prek for faster linting #143148

📚 Documentation preview 📚: https://cpython-previews--143149.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@juhannc
feat: replace pre-commit with prek
9854825
@juhannc
juhannc requested review from AA-Turner, ezio-melotti and hugovk as code owners December 24, 2025 15:40
@bedevere-app

bedevere-app Bot commented Dec 24, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@python-cla-bot

python-cla-bot Bot commented Dec 24, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Dec 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Dec 24, 2025
Replace pre-commit with prek for faster linting #143148
Closed
@blurb-it
📜🤖 Added by blurb_it.
20461ee
StanFromIreland
StanFromIreland reviewed Dec 24, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Tools-Demos/2025-12-24-15-47-53.gh-issue-143148.ODwnOQ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@juhannc
news: remove NEWS file as this is not user facing
ea073fd
@bedevere-app

bedevere-app Bot commented Dec 25, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juhannc added a commit to juhannc/devguide that referenced this pull request Dec 25, 2025
@juhannc
docs: reflect changes of python/cpython#143149
ac93772
@juhannc juhannc mentioned this pull request Dec 25, 2025
Replace pre-commit with prek python/devguide#1718
Open
@StanFromIreland StanFromIreland added the skip news label Dec 25, 2025
hugovk
hugovk approved these changes Dec 30, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 30, 2025
picnixz
picnixz requested changes Dec 30, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said on the issue, I'm against that change if I need to install prek.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 30, 2025
@bedevere-app

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting changes label Dec 30, 2025
@picnixz

picnixz commented Dec 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In addition, I believe such changes requires a NEWS entry (if we were to do it, and however we do it).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz removed the skip news label Dec 30, 2025
@bedevere-app

bedevere-app Bot commented Dec 30, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Dec 30, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's undo the changes to Makefile in this PR, and just update the CI in this one.

Then we can decide on the Makefile changes in another one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/Makefile Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/Makefile Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner @hugovk
Apply suggestions from code review
fef4655 
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Dec 31, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner reviewed Dec 31, 2025
View reviewed changes
Comment thread Doc/Makefile Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Update Doc/Makefile
e1e7d9c
@picnixz picnixz added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Dec 31, 2025
@AA-Turner

AA-Turner commented Dec 31, 2025

Copy link
Copy Markdown
Member

I am a little surprised that the action e.g. uses os.execvp (https://github.com/j178/prek-action/blob/main/action.yaml). One option for explitictness (especially in this repo) would be to download & run the prek-installer.sh without the indirection of the action.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jan 2, 2026

Copy link
Copy Markdown
Member

Let's use the action to simplify maintenance, but please do make suggestions upstream.
juhannc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk merged commit 864c598 into python:main Jan 2, 2026
86 of 89 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 2, 2026
@hugovk hugovk added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 2, 2026
@miss-islington-app

miss-islington-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

Thanks @juhannc for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@juhannc @hugovk
@blurb-it @AA-Turner @miss-islington
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
3b6f317 
(cherry picked from commit 864c598)

Co-authored-by: Johann Christensen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

GH-143359 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 2, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2026
@juhannc @hugovk
@blurb-it @AA-Turner @miss-islington
pythongh-143148: Replace pre-commit with prek in CI (pythonGH-143149)
d134301 
(cherry picked from commit 864c598)

Co-authored-by: Johann Christensen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 2, 2026

Copy link
Copy Markdown

GH-143360 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 2, 2026
hugovk added a commit that referenced this pull request Jan 2, 2026
@miss-islington @juhannc
@hugovk @blurb-it @AA-Turner
[3.13] gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
08c5bfe 
…3359)

Co-authored-by: Johann Christensen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <[email protected]>
hugovk added a commit that referenced this pull request Jan 2, 2026
@miss-islington @juhannc
@hugovk @blurb-it @AA-Turner
[3.14] gh-143148: Replace pre-commit with prek in CI (GH-143149) (#14…
935a366 
…3360)

Co-authored-by: Johann Christensen <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <[email protected]>
This was referenced Jan 2, 2026
Replace pre-commit with prek in CI python/bedevere#682
Merged
Replace pre-commit with prek in CI and add zizmor python/cherry-picker#172
Merged
Replace pre-commit with prek in CI python/blurb_it#438
Merged
Replace pre-commit with prek in CI python/python-docs-theme#293
Merged
Replace pre-commit with prek in CI python/release-tools#326
Merged
Add support for Python 3.15 python/docsbuild-scripts#322
Merged
Replace pre-commit with prek in CI and add Dependabot python/docsbuild-scripts#324
Merged
Replace pre-commit with prek in CI python/peps#4766
Merged
@ulgens ulgens mentioned this pull request Jan 3, 2026
Add python/cpython to users j178/prek#1308
Merged
@hugovk hugovk mentioned this pull request Jan 11, 2026
Replace pre-commit with prek in CI and add cooldown to Dependabot python/pyperformance#452
Merged
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@juhannc @hugovk
@blurb-it @AA-Turner @thunder-coding
pythongh-143148: Replace pre-commit with prek in CI (python#143149)
d6d40dc 
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Adam Turner <[email protected]>
@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Mar 4, 2026
Run prek as a GitHub Action poldracklab/pydeface#67
Closed
@vivodi vivodi mentioned this pull request Mar 23, 2026
Replace prek GitHub Action with pre-commit.ci GitHub app for better performance #146317
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner left review comments
@StanFromIreland StanFromIreland StanFromIreland left review comments
@picnixz picnixz picnixz approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace pre-commit with prek for faster linting

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@juhannc @picnixz @AA-Turner @hugovk @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.