GeezerVison is showing github.com — Replace pre-commit with prek in CI by hugovk · Pull Request #4766 · python/peps
Conversation
hugovk
commented
Jan 2, 2026
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hugovk ! FWIW, while I've been a big pre-commit fan in the past, prek brings significant longstanding improvements to performance, features and community trust. While I know some other devs have concerns about moving too quickly, and I agree keeping compat with pre-commit for the time being is the way to go, FWIW in terms of trust and reliability that others were concerned about, pretty much anything is a net improvement over pre-commit in that department, as many other CPython maintainers and Python community members can attest from firsthand experience 😉 .
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
dhimmel reacted with thumbs up emoji
|
Yep, and like python/cpython#143148, this only updates the CI and not the Makefile or docs (README.rst, CONTRIBUTING.rst).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
AA-Turner
Awaiting requested review from AA-Turner
AA-Turner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.