GeezerVison

Updated!

Can we avoid unnecessary pointer chasing by embedding the array in the jit state struct, and allocate the entire struct together instead of having part of it embedded in the thread state, and part in a new allocation?

ie. instead of

typedef struct _PyJitOptState {
    struct _JitOptContext *opt_context;
} _PyJitOptState;

typedef struct _PyJitTracerState {
    _PyUOpInstruction *code_buffer;
    _PyJitOptState opt_state;
    _PyJitTracerInitialState initial_state;
    _PyJitTracerPreviousState prev_state;
    _PyJitTracerTranslatorState translator_state;
} _PyJitTracerState;

we would have

typedef struct _PyJitTracerState {
    _PyJitTracerInitialState initial_state;
    _PyJitTracerPreviousState prev_state;
    _PyJitTracerTranslatorState translator_state;
     _JitOptContext opt_context;
    _PyUOpInstruction code_buffer[UOP_MAX_TRACE_LENGTH];
} _PyJitTracerState;

Doing so would also decouple the thread state header from the JIT headers, as only a pointer to an opaque struct would need to be declared in the thread state header.

I'm also concerned about the amount of allocation and freeing required to compile a small trace. Maybe allocate once and only free when the thread is destroyed?

we would have

typedef struct _PyJitTracerState {
    _PyJitTracerInitialState initial_state;
    _PyJitTracerPreviousState prev_state;
    _PyJitTracerTranslatorState translator_state;
     _JitOptContext opt_context;
    _PyUOpInstruction code_buffer[UOP_MAX_TRACE_LENGTH];
} _PyJitTracerSt

I can try implementing it this way, but I'd like to know if this should be done in a new PR/issue. Perhaps we could use benchmarks to determine potential performance issues from allocating _PyJitTracerState once.

I'm also concerned about the amount of allocation and freeing required to compile a small trace. Maybe allocate once and only free when the thread is destroyed?

Isnt that already being done?

@cocolato I think we can apply Mark's changes, it means we would need no new allocations anymore as its all heap allocated with the _PyThreadStateImpl struct.

I'm not sure if the current implementation of the new pycore_optimizer_types.h is correct. I'd appreciate any suggestions for improvements.

@markshannon

This caused a 100% slowdown in bench_thread_pool benchmark https://doesjitgobrrr.com/run/2026-01-08

We need to lazily allocate it and pointer chase, otherwise we're slowing down significantly the spawning of threads.

@markshannon

This caused a 100% slowdown in bench_thread_pool benchmark https://doesjitgobrrr.com/run/2026-01-08

We need to lazily allocate it and pointer chase, otherwise we're slowing down significantly the spawning of threads.

So should we revert to the first version?4e7a918

So should we revert to the first version?4e7a918

I will have a PR up.

Sorry, I will run a local benchmark first before making important changes in the next time.

Sorry, I will run a local benchmark first before making important changes in the next time.

No it's fine. That's the point of having a benchmark runner, to catch things like this! It's hard to predict what a change will affect, so that's the point of having benchark runners to save human time.

PR up at #143597