GeezerVison

Should we remove the newly added pycore_optimizer_types.h?

Should we remove the newly added pycore_optimizer_types.h?

Let's keep it. It's a good refactor.

This makes no sense to me. How is allocating the necessary memory piecemeal faster than allocating it in a single chunk?

@markshannon no the problem was embedding it as a part of _PyThreadStateImpl, that caused a 100% slowdown of thread spawning time on the benchmark, which reflected in bench_thread_pool.

The benchmark doesn't run any work to use the JIT, instead it just measures thread startup overhead https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_concurrent_imap/run_benchmark.py#L19

Embedding the two structs together in the _PyThreadStateImpl causes a massive slowdown.

It shouldn't be embedded, it should be heap allocated as one
#143536 (comment)

It shouldn't be embedded, it should be heap allocated as one #143536 (comment)

Ok let me just put a up a PR to do that.