GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143754: Modernize Tkinter docs by serhiy-storchaka · Pull Request #143841 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 14, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use more up to date terminology instead of "master"/"slave" widgets where it is possible.

  • Issue: tkinter source and docs use the word 'slave' #143754

📚 Documentation preview 📚: https://cpython-previews--143841.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
pythongh-143754: Modernize Tkinter docs
cd9ede3
Use more up to date terminology instead of "master"/"slave" widgets
where it is possible.
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy January 14, 2026 17:48
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jan 14, 2026
@github-project-automation github-project-automation Bot added this to Docs PRs Jan 14, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jan 14, 2026
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 14, 2026
tkinter source and docs use the word 'slave' #143754
Closed
@serhiy-storchaka

serhiy-storchaka commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

I used the modern Tk documentation to update the Tkinter documentation.

terryjreedy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 14, 2026
gh-143754: Add Tkinter methods pack_content(), place_content() and grid_content() #143845
Merged
terryjreedy
terryjreedy reviewed Jan 19, 2026
View reviewed changes
Comment thread Lib/tkinter/__init__.py
Comment on lines 2669 to 2670
width=amount - width of this widget in pixel
height=amount - height of this widget in pixel

@terryjreedy terryjreedy Jan 19, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
width=amount - width of this widget in pixel
height=amount - height of this widget in pixel
width=amount - width of this widget in pixels
height=amount - height of this widget in pixels

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@serhiy-storchaka serhiy-storchaka Jan 19, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other occurrences of "in pixel" in other places, so I think it is better to fix them in a separate PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@serhiy-storchaka serhiy-storchaka Jan 19, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, the Tk documentation says "in screen units", because not only pixels are supported. You can use millimeters or inches, etc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
terryjreedy
terryjreedy reviewed Jan 19, 2026
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved except for pluralizing 'pixel'.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
serhiy-storchaka merged commit 813fc7a into python:main Jan 19, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jan 19, 2026
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 19, 2026
@miss-islington-app

miss-islington-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka deleted the tkinter-master-slave-docs branch January 19, 2026 12:01
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
@serhiy-storchaka @miss-islington
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
8dc032d
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2026
@serhiy-storchaka @miss-islington
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
5e494ba
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144032 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jan 19, 2026
@bedevere-app

bedevere-app Bot commented Jan 19, 2026

Copy link
Copy Markdown

GH-144033 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jan 19, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-143754: Modernize Tkinter docs (GH-143841) (GH-144033)
48a8cd1
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Jan 19, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-143754: Modernize Tkinter docs (GH-143841) (GH-144032)
5573df1
Use more relevant terminology instead of "master"/"slave" widgets where possible.
(cherry picked from commit 813fc7a)

Co-authored-by: Serhiy Storchaka <[email protected]>
@vstinner

vstinner commented Jan 19, 2026

Copy link
Copy Markdown
Member

Nice change, thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jan 19, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1736) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1736

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jan 19, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.13 (tier-2) has failed when building commit 48a8cd1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1396/builds/1968) and take a look at the build logs.
  4. Check if the failure is related to this commit (48a8cd1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1396/builds/1968

Failed tests:

  • test.test_multiprocessing_spawn.test_processes
  • test.test_multiprocessing_forkserver.test_processes

Failed subtests:

  • test_repr_rlock - test.test_multiprocessing_spawn.test_processes.WithProcessesTestLock.test_repr_rlock
  • test_repr_rlock - test.test_multiprocessing_forkserver.test_processes.WithProcessesTestLock.test_repr_rlock

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1493, in test_repr_rlock
    self.assertEqual('<RLock(SomeOtherThread, nonzero)>', repr(lock))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: '<RLock(SomeOtherThread, nonzero)>' != '<RLock(None, 0)>'
- <RLock(SomeOtherThread, nonzero)>
+ <RLock(None, 0)>
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @thunder-coding
pythongh-143754: Modernize Tkinter docs (pythonGH-143841)
a4e5656
Use more relevant terminology instead of "master"/"slave" widgets where possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @vstinner @bedevere-bot @terryjreedy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.